Commit 3a334ea5 authored by Eva Rachel Retuya's avatar Eva Rachel Retuya Committed by Greg Kroah-Hartman

staging: fbtft: Modify block comments based on kernel coding style

Add the required trailing * on subsequent lines as well as move the */
on a separate line. Checkpatch found this issue.
Signed-off-by: default avatarEva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 63986883
...@@ -39,11 +39,11 @@ ...@@ -39,11 +39,11 @@
#endif #endif
/* ILI9163C commands */ /* ILI9163C commands */
#define CMD_FRMCTR1 0xB1 /* Frame Rate Control #define CMD_FRMCTR1 0xB1 /* Frame Rate Control */
(In normal mode/Full colors) */ /* (In normal mode/Full colors) */
#define CMD_FRMCTR2 0xB2 /* Frame Rate Control (In Idle mode/8-colors) */ #define CMD_FRMCTR2 0xB2 /* Frame Rate Control (In Idle mode/8-colors) */
#define CMD_FRMCTR3 0xB3 /* Frame Rate Control #define CMD_FRMCTR3 0xB3 /* Frame Rate Control */
(In Partial mode/full colors) */ /* (In Partial mode/full colors) */
#define CMD_DINVCTR 0xB4 /* Display Inversion Control */ #define CMD_DINVCTR 0xB4 /* Display Inversion Control */
#define CMD_RGBBLK 0xB5 /* RGB Interface Blanking Porch setting */ #define CMD_RGBBLK 0xB5 /* RGB Interface Blanking Porch setting */
#define CMD_DFUNCTR 0xB6 /* Display Function set 5 */ #define CMD_DFUNCTR 0xB6 /* Display Function set 5 */
...@@ -63,17 +63,18 @@ ...@@ -63,17 +63,18 @@
#define CMD_GAMRSEL 0xF2 /* GAM_R_SEL */ #define CMD_GAMRSEL 0xF2 /* GAM_R_SEL */
/* /*
This display: * This display:
http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271 * http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
This particular display has a design error! The controller has 3 pins to * Color-TFT-LCD-Display-Module-/271422122271
configure to constrain the memory and resolution to a fixed dimension (in * This particular display has a design error! The controller has 3 pins to
that case 128x128) but they leaved those pins configured for 128x160 so * configure to constrain the memory and resolution to a fixed dimension (in
there was several pixel memory addressing problems. * that case 128x128) but they leaved those pins configured for 128x160 so
I solved by setup several parameters that dinamically fix the resolution as * there was several pixel memory addressing problems.
needit so below the parameters for this display. If you have a strain or a * I solved by setup several parameters that dinamically fix the resolution as
correct display (can happen with chinese) you can copy those parameters and * needit so below the parameters for this display. If you have a strain or a
create setup for different displays. * correct display (can happen with chinese) you can copy those parameters and
*/ * create setup for different displays.
*/
#ifdef RED #ifdef RED
#define __OFFSET 32 /*see note 2 - this is the red version */ #define __OFFSET 32 /*see note 2 - this is the red version */
...@@ -153,25 +154,25 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, ...@@ -153,25 +154,25 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys,
} }
/* /*
7) MY: 1(bottom to top), 0(top to bottom) Row Address Order * 7) MY: 1(bottom to top), 0(top to bottom) Row Address Order
6) MX: 1(R to L), 0(L to R) Column Address Order * 6) MX: 1(R to L), 0(L to R) Column Address Order
5) MV: 1(Exchanged), 0(normal) Row/Column exchange * 5) MV: 1(Exchanged), 0(normal) Row/Column exchange
4) ML: 1(bottom to top), 0(top to bottom) Vertical Refresh Order * 4) ML: 1(bottom to top), 0(top to bottom) Vertical Refresh Order
3) RGB: 1(BGR), 0(RGB) Color Space * 3) RGB: 1(BGR), 0(RGB) Color Space
2) MH: 1(R to L), 0(L to R) Horizontal Refresh Order * 2) MH: 1(R to L), 0(L to R) Horizontal Refresh Order
1) * 1)
0) * 0)
*
MY, MX, MV, ML,RGB, MH, D1, D0 * MY, MX, MV, ML,RGB, MH, D1, D0
0 | 0 | 0 | 0 | 1 | 0 | 0 | 0 //normal * 0 | 0 | 0 | 0 | 1 | 0 | 0 | 0 //normal
1 | 0 | 0 | 0 | 1 | 0 | 0 | 0 //Y-Mirror * 1 | 0 | 0 | 0 | 1 | 0 | 0 | 0 //Y-Mirror
0 | 1 | 0 | 0 | 1 | 0 | 0 | 0 //X-Mirror * 0 | 1 | 0 | 0 | 1 | 0 | 0 | 0 //X-Mirror
1 | 1 | 0 | 0 | 1 | 0 | 0 | 0 //X-Y-Mirror * 1 | 1 | 0 | 0 | 1 | 0 | 0 | 0 //X-Y-Mirror
0 | 0 | 1 | 0 | 1 | 0 | 0 | 0 //X-Y Exchange * 0 | 0 | 1 | 0 | 1 | 0 | 0 | 0 //X-Y Exchange
1 | 0 | 1 | 0 | 1 | 0 | 0 | 0 //X-Y Exchange, Y-Mirror * 1 | 0 | 1 | 0 | 1 | 0 | 0 | 0 //X-Y Exchange, Y-Mirror
0 | 1 | 1 | 0 | 1 | 0 | 0 | 0 //XY exchange * 0 | 1 | 1 | 0 | 1 | 0 | 0 | 0 //XY exchange
1 | 1 | 1 | 0 | 1 | 0 | 0 | 0 * 1 | 1 | 1 | 0 | 1 | 0 | 0 | 0
*/ */
static int set_var(struct fbtft_par *par) static int set_var(struct fbtft_par *par)
{ {
u8 mactrl_data = 0; /* Avoid compiler warning */ u8 mactrl_data = 0; /* Avoid compiler warning */
......
...@@ -216,10 +216,10 @@ static int set_var(struct fbtft_par *par) ...@@ -216,10 +216,10 @@ static int set_var(struct fbtft_par *par)
} }
/* /*
Gamma string format: * Gamma string format:
VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5 * VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5 * VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
*/ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx] #define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves) static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{ {
......
...@@ -56,42 +56,42 @@ module_param(vcm, uint, 0); ...@@ -56,42 +56,42 @@ module_param(vcm, uint, 0);
MODULE_PARM_DESC(vcm, "Set the internal VcomH voltage"); MODULE_PARM_DESC(vcm, "Set the internal VcomH voltage");
/* /*
Verify that this configuration is within the Voltage limits * Verify that this configuration is within the Voltage limits
*
Display module configuration: Vcc = IOVcc = Vci = 3.3V * Display module configuration: Vcc = IOVcc = Vci = 3.3V
*
Voltages * Voltages
---------- * ----------
Vci = 3.3 * Vci = 3.3
Vci1 = Vci * 0.80 = 2.64 * Vci1 = Vci * 0.80 = 2.64
DDVDH = Vci1 * 2 = 5.28 * DDVDH = Vci1 * 2 = 5.28
VCL = -Vci1 = -2.64 * VCL = -Vci1 = -2.64
VREG1OUT = Vci * 1.85 = 4.88 * VREG1OUT = Vci * 1.85 = 4.88
VCOMH = VREG1OUT * 0.735 = 3.59 * VCOMH = VREG1OUT * 0.735 = 3.59
VCOM amplitude = VREG1OUT * 0.98 = 4.79 * VCOM amplitude = VREG1OUT * 0.98 = 4.79
VGH = Vci * 4 = 13.2 * VGH = Vci * 4 = 13.2
VGL = -Vci * 4 = -13.2 * VGL = -Vci * 4 = -13.2
*
Limits * Limits
-------- * --------
Power supplies * Power supplies
1.65 < IOVcc < 3.30 => 1.65 < 3.3 < 3.30 * 1.65 < IOVcc < 3.30 => 1.65 < 3.3 < 3.30
2.40 < Vcc < 3.30 => 2.40 < 3.3 < 3.30 * 2.40 < Vcc < 3.30 => 2.40 < 3.3 < 3.30
2.50 < Vci < 3.30 => 2.50 < 3.3 < 3.30 * 2.50 < Vci < 3.30 => 2.50 < 3.3 < 3.30
*
Source/VCOM power supply voltage * Source/VCOM power supply voltage
4.50 < DDVDH < 6.0 => 4.50 < 5.28 < 6.0 * 4.50 < DDVDH < 6.0 => 4.50 < 5.28 < 6.0
-3.0 < VCL < -2.0 => -3.0 < -2.64 < -2.0 * -3.0 < VCL < -2.0 => -3.0 < -2.64 < -2.0
VCI - VCL < 6.0 => 5.94 < 6.0 * VCI - VCL < 6.0 => 5.94 < 6.0
*
Gate driver output voltage * Gate driver output voltage
10 < VGH < 20 => 10 < 13.2 < 20 * 10 < VGH < 20 => 10 < 13.2 < 20
-15 < VGL < -5 => -15 < -13.2 < -5 * -15 < VGL < -5 => -15 < -13.2 < -5
VGH - VGL < 32 => 26.4 < 32 * VGH - VGL < 32 => 26.4 < 32
*
VCOM driver output voltage * VCOM driver output voltage
VCOMH - VCOML < 6.0 => 4.79 < 6.0 * VCOMH - VCOML < 6.0 => 4.79 < 6.0
*/ */
static int init_display(struct fbtft_par *par) static int init_display(struct fbtft_par *par)
{ {
...@@ -213,10 +213,10 @@ static int set_var(struct fbtft_par *par) ...@@ -213,10 +213,10 @@ static int set_var(struct fbtft_par *par)
} }
/* /*
Gamma string format: * Gamma string format:
VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5 * VRP0 VRP1 RP0 RP1 KP0 KP1 KP2 KP3 KP4 KP5
VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5 * VRN0 VRN1 RN0 RN1 KN0 KN1 KN2 KN3 KN4 KN5
*/ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx] #define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves) static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{ {
......
...@@ -116,10 +116,10 @@ static int set_var(struct fbtft_par *par) ...@@ -116,10 +116,10 @@ static int set_var(struct fbtft_par *par)
} }
/* /*
Gamma string format: * Gamma string format:
Positive: Par1 Par2 [...] Par15 * Positive: Par1 Par2 [...] Par15
Negative: Par1 Par2 [...] Par15 * Negative: Par1 Par2 [...] Par15
*/ */
#define CURVE(num, idx) curves[num * par->gamma.num_values + idx] #define CURVE(num, idx) curves[num * par->gamma.num_values + idx]
static int set_gamma(struct fbtft_par *par, unsigned long *curves) static int set_gamma(struct fbtft_par *par, unsigned long *curves)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment