Commit 3a55234d authored by Wei Yongjun's avatar Wei Yongjun Committed by Kleber Sacilotto de Souza

net: axienet: Fix return value check in axienet_probe()

BugLink: https://bugs.launchpad.net/bugs/1878232

commit 3ad7b147 upstream.

In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 46aa27df ('net: axienet: Use devm_* calls')
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarIan May <ian.may@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent fe1b9881
...@@ -1602,9 +1602,9 @@ static int axienet_probe(struct platform_device *pdev) ...@@ -1602,9 +1602,9 @@ static int axienet_probe(struct platform_device *pdev)
/* Find the DMA node, map the DMA registers, and decode the DMA IRQs */ /* Find the DMA node, map the DMA registers, and decode the DMA IRQs */
np = of_parse_phandle(pdev->dev.of_node, "axistream-connected", 0); np = of_parse_phandle(pdev->dev.of_node, "axistream-connected", 0);
if (IS_ERR(np)) { if (!np) {
dev_err(&pdev->dev, "could not find DMA node\n"); dev_err(&pdev->dev, "could not find DMA node\n");
ret = PTR_ERR(np); ret = -ENODEV;
goto free_netdev; goto free_netdev;
} }
ret = of_address_to_resource(np, 0, &dmares); ret = of_address_to_resource(np, 0, &dmares);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment