Commit 3a5f3d61 authored by Paul Cercueil's avatar Paul Cercueil Committed by Robert Foss

drm/bridge: it66121: Initialize {device,vendor}_ids

These two arrays are populated with data read from the I2C device
through regmap_read(), and the data is then compared with hardcoded
vendor/product ID values of supported chips.

However, the return value of regmap_read() was never checked. This is
fine, as long as the two arrays are zero-initialized, so that we don't
compare the vendor/product IDs against whatever garbage is left on the
stack.

Address this issue by zero-initializing these two arrays.
Signed-off-by: default avatarPaul Cercueil <paul@crapouillou.net>
Fixes: 988156dc ("drm: bridge: add it66121 driver")
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210827163956.27517-1-paul@crapouillou.net
parent c9d7b282
...@@ -889,7 +889,7 @@ static irqreturn_t it66121_irq_threaded_handler(int irq, void *dev_id) ...@@ -889,7 +889,7 @@ static irqreturn_t it66121_irq_threaded_handler(int irq, void *dev_id)
static int it66121_probe(struct i2c_client *client, static int it66121_probe(struct i2c_client *client,
const struct i2c_device_id *id) const struct i2c_device_id *id)
{ {
u32 vendor_ids[2], device_ids[2], revision_id; u32 revision_id, vendor_ids[2] = { 0 }, device_ids[2] = { 0 };
struct device_node *ep; struct device_node *ep;
int ret; int ret;
struct it66121_ctx *ctx; struct it66121_ctx *ctx;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment