Commit 3a85969e authored by Tetsuo Handa's avatar Tetsuo Handa Committed by Ingo Molnar

lockdep: Add a missing initialization hint to the "INFO: Trying to register non-static key" message

Since this message is printed when dynamically allocated spinlocks (e.g.
kzalloc()) are used without initialization (e.g. spin_lock_init()),
suggest to developers to check whether initialization functions for objects
were called, before making developers wonder what annotation is missing.

[ mingo: Minor tweaks to the message. ]
Signed-off-by: default avatarTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210321064913.4619-1-penguin-kernel@I-love.SAKURA.ne.jpSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 2dc0572f
...@@ -930,7 +930,8 @@ static bool assign_lock_key(struct lockdep_map *lock) ...@@ -930,7 +930,8 @@ static bool assign_lock_key(struct lockdep_map *lock)
/* Debug-check: all keys must be persistent! */ /* Debug-check: all keys must be persistent! */
debug_locks_off(); debug_locks_off();
pr_err("INFO: trying to register non-static key.\n"); pr_err("INFO: trying to register non-static key.\n");
pr_err("the code is fine but needs lockdep annotation.\n"); pr_err("The code is fine but needs lockdep annotation, or maybe\n");
pr_err("you didn't initialize this object before use?\n");
pr_err("turning off the locking correctness validator.\n"); pr_err("turning off the locking correctness validator.\n");
dump_stack(); dump_stack();
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment