Commit 3bac8d2b authored by Luiz Capitulino's avatar Luiz Capitulino Committed by Greg Kroah-Hartman

[PATCH] USB: remove ugly code from usb/serial/usb-serial.c.

 This patch removes ugly code from some function in usb/serial/usb-serial.c
which is using a goto statement intead of a simple `return'.

 To be true, I'm not certain if there is a special reason to do that, if so
ignore me. ;)
Signed-off-by: default avatarLuiz Capitulino <lcapitulino@conectiva.com.br>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent 190b5799
...@@ -621,15 +621,12 @@ static void serial_throttle (struct tty_struct * tty) ...@@ -621,15 +621,12 @@ static void serial_throttle (struct tty_struct * tty)
if (!port->open_count) { if (!port->open_count) {
dbg ("%s - port not open", __FUNCTION__); dbg ("%s - port not open", __FUNCTION__);
goto exit; return;
} }
/* pass on to the driver specific version of this function */ /* pass on to the driver specific version of this function */
if (port->serial->type->throttle) if (port->serial->type->throttle)
port->serial->type->throttle(port); port->serial->type->throttle(port);
exit:
;
} }
static void serial_unthrottle (struct tty_struct * tty) static void serial_unthrottle (struct tty_struct * tty)
...@@ -640,15 +637,12 @@ static void serial_unthrottle (struct tty_struct * tty) ...@@ -640,15 +637,12 @@ static void serial_unthrottle (struct tty_struct * tty)
if (!port->open_count) { if (!port->open_count) {
dbg("%s - port not open", __FUNCTION__); dbg("%s - port not open", __FUNCTION__);
goto exit; return;
} }
/* pass on to the driver specific version of this function */ /* pass on to the driver specific version of this function */
if (port->serial->type->unthrottle) if (port->serial->type->unthrottle)
port->serial->type->unthrottle(port); port->serial->type->unthrottle(port);
exit:
;
} }
static int serial_ioctl (struct tty_struct *tty, struct file * file, unsigned int cmd, unsigned long arg) static int serial_ioctl (struct tty_struct *tty, struct file * file, unsigned int cmd, unsigned long arg)
...@@ -681,15 +675,12 @@ static void serial_set_termios (struct tty_struct *tty, struct termios * old) ...@@ -681,15 +675,12 @@ static void serial_set_termios (struct tty_struct *tty, struct termios * old)
if (!port->open_count) { if (!port->open_count) {
dbg("%s - port not open", __FUNCTION__); dbg("%s - port not open", __FUNCTION__);
goto exit; return;
} }
/* pass on to the driver specific version of this function if it is available */ /* pass on to the driver specific version of this function if it is available */
if (port->serial->type->set_termios) if (port->serial->type->set_termios)
port->serial->type->set_termios(port, old); port->serial->type->set_termios(port, old);
exit:
;
} }
static void serial_break (struct tty_struct *tty, int break_state) static void serial_break (struct tty_struct *tty, int break_state)
...@@ -700,15 +691,12 @@ static void serial_break (struct tty_struct *tty, int break_state) ...@@ -700,15 +691,12 @@ static void serial_break (struct tty_struct *tty, int break_state)
if (!port->open_count) { if (!port->open_count) {
dbg("%s - port not open", __FUNCTION__); dbg("%s - port not open", __FUNCTION__);
goto exit; return;
} }
/* pass on to the driver specific version of this function if it is available */ /* pass on to the driver specific version of this function if it is available */
if (port->serial->type->break_ctl) if (port->serial->type->break_ctl)
port->serial->type->break_ctl(port, break_state); port->serial->type->break_ctl(port, break_state);
exit:
;
} }
static int serial_read_proc (char *page, char **start, off_t off, int count, int *eof, void *data) static int serial_read_proc (char *page, char **start, off_t off, int count, int *eof, void *data)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment