Commit 3bcd4772 authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

net: phy: phylink: Don't release NULL GPIO

If CONFIG_GPIOLIB is disabled, gpiod_put() becomes a stub that produces a
warning, this helped identify that we could be attempting to release a NULL
pl->link_gpio GPIO descriptor, so guard against that.

Fixes: daab3349 ("net: phy: phylink: Release link GPIO")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7ddae24f
...@@ -624,7 +624,7 @@ void phylink_destroy(struct phylink *pl) ...@@ -624,7 +624,7 @@ void phylink_destroy(struct phylink *pl)
{ {
if (pl->sfp_bus) if (pl->sfp_bus)
sfp_unregister_upstream(pl->sfp_bus); sfp_unregister_upstream(pl->sfp_bus);
if (!IS_ERR(pl->link_gpio)) if (!IS_ERR_OR_NULL(pl->link_gpio))
gpiod_put(pl->link_gpio); gpiod_put(pl->link_gpio);
cancel_work_sync(&pl->resolve); cancel_work_sync(&pl->resolve);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment