Commit 3bd78726 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Khalid Elmously

ppp: Adjust indentation into ppp_async_input

BugLink: https://bugs.launchpad.net/bugs/1864775

commit 08cbc75f upstream.

Clang warns:

../drivers/net/ppp/ppp_async.c:877:6: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]
                                ap->rpkt = skb;
                                ^
../drivers/net/ppp/ppp_async.c:875:5: note: previous statement is here
                                if (!skb)
                                ^
1 warning generated.

This warning occurs because there is a space before the tab on this
line. Clean up this entire block's indentation so that it is consistent
with the Linux kernel coding style and clang no longer warns.

Fixes: 6722e78c ("[PPP]: handle misaligned accesses")
Link: https://github.com/ClangBuiltLinux/linux/issues/800Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 98b313ca
...@@ -878,15 +878,15 @@ ppp_async_input(struct asyncppp *ap, const unsigned char *buf, ...@@ -878,15 +878,15 @@ ppp_async_input(struct asyncppp *ap, const unsigned char *buf,
skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2); skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2);
if (!skb) if (!skb)
goto nomem; goto nomem;
ap->rpkt = skb; ap->rpkt = skb;
} }
if (skb->len == 0) { if (skb->len == 0) {
/* Try to get the payload 4-byte aligned. /* Try to get the payload 4-byte aligned.
* This should match the * This should match the
* PPP_ALLSTATIONS/PPP_UI/compressed tests in * PPP_ALLSTATIONS/PPP_UI/compressed tests in
* process_input_packet, but we do not have * process_input_packet, but we do not have
* enough chars here to test buf[1] and buf[2]. * enough chars here to test buf[1] and buf[2].
*/ */
if (buf[0] != PPP_ALLSTATIONS) if (buf[0] != PPP_ALLSTATIONS)
skb_reserve(skb, 2 + (buf[0] & 1)); skb_reserve(skb, 2 + (buf[0] & 1));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment