Commit 3beb9be1 authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Jakub Kicinski

qlcnic: fix error return code in qlcnic_83xx_restart_hw()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3ced0a88 ("qlcnic: Add support to run firmware POST")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1605248186-16013-1-git-send-email-zhangchangzhong@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent cfbaa8b3
...@@ -2231,7 +2231,8 @@ static int qlcnic_83xx_restart_hw(struct qlcnic_adapter *adapter) ...@@ -2231,7 +2231,8 @@ static int qlcnic_83xx_restart_hw(struct qlcnic_adapter *adapter)
/* Boot either flash image or firmware image from host file system */ /* Boot either flash image or firmware image from host file system */
if (qlcnic_load_fw_file == 1) { if (qlcnic_load_fw_file == 1) {
if (qlcnic_83xx_load_fw_image_from_host(adapter)) err = qlcnic_83xx_load_fw_image_from_host(adapter);
if (err)
return err; return err;
} else { } else {
QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID, QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment