Commit 3c554881 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by David S. Miller

net: ax88796c: Fix clang -Wimplicit-fallthrough in ax88796c_set_mac()

Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:696:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        case SPEED_10:
        ^
drivers/net/ethernet/asix/ax88796c_main.c:696:2: note: insert 'break;' to avoid fall-through
        case SPEED_10:
        ^
        break;
drivers/net/ethernet/asix/ax88796c_main.c:706:2: error: unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        case DUPLEX_HALF:
        ^
drivers/net/ethernet/asix/ax88796c_main.c:706:2: note: insert 'break;' to avoid fall-through
        case DUPLEX_HALF:
        ^
        break;

Clang is a little more pedantic than GCC, which permits implicit
fallthroughs to cases that contain just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing breaks to fix
the warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1491Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a137c069
......@@ -693,6 +693,7 @@ static void ax88796c_set_mac(struct ax88796c_device *ax_local)
switch (ax_local->speed) {
case SPEED_100:
maccr |= MACCR_SPEED_100;
break;
case SPEED_10:
case SPEED_UNKNOWN:
break;
......@@ -703,6 +704,7 @@ static void ax88796c_set_mac(struct ax88796c_device *ax_local)
switch (ax_local->duplex) {
case DUPLEX_FULL:
maccr |= MACCR_SPEED_100;
break;
case DUPLEX_HALF:
case DUPLEX_UNKNOWN:
break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment