Commit 3cc4a84e authored by Eric Dumazet's avatar Eric Dumazet Committed by Al Viro

proc: add a reschedule point in proc_readfd_common()

User can pass an arbitrary large buffer to getdents().

It is typically a 32KB buffer used by libc scandir() implementation.

When scanning /proc/{pid}/fd, we can hold cpu way too long,
so add a cond_resched() to be kind with other tasks.

We've seen latencies of more than 50ms on real workloads.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent bc51b2a9
...@@ -258,6 +258,7 @@ static int proc_readfd_common(struct file *file, struct dir_context *ctx, ...@@ -258,6 +258,7 @@ static int proc_readfd_common(struct file *file, struct dir_context *ctx,
name, len, instantiate, p, name, len, instantiate, p,
(void *)(unsigned long)fd)) (void *)(unsigned long)fd))
goto out_fd_loop; goto out_fd_loop;
cond_resched();
rcu_read_lock(); rcu_read_lock();
} }
rcu_read_unlock(); rcu_read_unlock();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment