Commit 3d07df11 authored by Ben Hutchings's avatar Ben Hutchings Committed by David S. Miller

sfc: Add necessary parentheses to macro definitions in net_driver.h

Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fa236e18
...@@ -926,8 +926,8 @@ struct efx_nic_type { ...@@ -926,8 +926,8 @@ struct efx_nic_type {
/* Iterate over all used channels */ /* Iterate over all used channels */
#define efx_for_each_channel(_channel, _efx) \ #define efx_for_each_channel(_channel, _efx) \
for (_channel = &_efx->channel[0]; \ for (_channel = &((_efx)->channel[0]); \
_channel < &_efx->channel[EFX_MAX_CHANNELS]; \ _channel < &((_efx)->channel[EFX_MAX_CHANNELS]); \
_channel++) \ _channel++) \
if (!_channel->used_flags) \ if (!_channel->used_flags) \
continue; \ continue; \
...@@ -935,31 +935,31 @@ struct efx_nic_type { ...@@ -935,31 +935,31 @@ struct efx_nic_type {
/* Iterate over all used TX queues */ /* Iterate over all used TX queues */
#define efx_for_each_tx_queue(_tx_queue, _efx) \ #define efx_for_each_tx_queue(_tx_queue, _efx) \
for (_tx_queue = &_efx->tx_queue[0]; \ for (_tx_queue = &((_efx)->tx_queue[0]); \
_tx_queue < &_efx->tx_queue[EFX_TX_QUEUE_COUNT]; \ _tx_queue < &((_efx)->tx_queue[EFX_TX_QUEUE_COUNT]); \
_tx_queue++) _tx_queue++)
/* Iterate over all TX queues belonging to a channel */ /* Iterate over all TX queues belonging to a channel */
#define efx_for_each_channel_tx_queue(_tx_queue, _channel) \ #define efx_for_each_channel_tx_queue(_tx_queue, _channel) \
for (_tx_queue = &_channel->efx->tx_queue[0]; \ for (_tx_queue = &((_channel)->efx->tx_queue[0]); \
_tx_queue < &_channel->efx->tx_queue[EFX_TX_QUEUE_COUNT]; \ _tx_queue < &((_channel)->efx->tx_queue[EFX_TX_QUEUE_COUNT]); \
_tx_queue++) \ _tx_queue++) \
if (_tx_queue->channel != _channel) \ if (_tx_queue->channel != (_channel)) \
continue; \ continue; \
else else
/* Iterate over all used RX queues */ /* Iterate over all used RX queues */
#define efx_for_each_rx_queue(_rx_queue, _efx) \ #define efx_for_each_rx_queue(_rx_queue, _efx) \
for (_rx_queue = &_efx->rx_queue[0]; \ for (_rx_queue = &((_efx)->rx_queue[0]); \
_rx_queue < &_efx->rx_queue[_efx->n_rx_queues]; \ _rx_queue < &((_efx)->rx_queue[(_efx)->n_rx_queues]); \
_rx_queue++) _rx_queue++)
/* Iterate over all RX queues belonging to a channel */ /* Iterate over all RX queues belonging to a channel */
#define efx_for_each_channel_rx_queue(_rx_queue, _channel) \ #define efx_for_each_channel_rx_queue(_rx_queue, _channel) \
for (_rx_queue = &_channel->efx->rx_queue[_channel->channel]; \ for (_rx_queue = &((_channel)->efx->rx_queue[(_channel)->channel]); \
_rx_queue; \ _rx_queue; \
_rx_queue = NULL) \ _rx_queue = NULL) \
if (_rx_queue->channel != _channel) \ if (_rx_queue->channel != (_channel)) \
continue; \ continue; \
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment