Commit 3d3d65bd authored by Denis Osterland-Heim's avatar Denis Osterland-Heim Committed by Pavel Machek

leds: pwm: add support for default-state device property

This patch adds support for "default-state" devicetree property, which
allows to defer pwm init to first use of led.

This allows to configure the PWM early in bootloader to let the LED
blink until an application in Linux userspace sets something different.
Signed-off-by: default avatarDenis Osterland-Heim <Denis.Osterland@diehl.com>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 791bc411
...@@ -17,10 +17,12 @@ ...@@ -17,10 +17,12 @@
#include <linux/err.h> #include <linux/err.h>
#include <linux/pwm.h> #include <linux/pwm.h>
#include <linux/slab.h> #include <linux/slab.h>
#include "leds.h"
struct led_pwm { struct led_pwm {
const char *name; const char *name;
u8 active_low; u8 active_low;
u8 default_state;
unsigned int max_brightness; unsigned int max_brightness;
}; };
...@@ -77,7 +79,38 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, ...@@ -77,7 +79,38 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
led_data->cdev.brightness_set_blocking = led_pwm_set; led_data->cdev.brightness_set_blocking = led_pwm_set;
pwm_init_state(led_data->pwm, &led_data->pwmstate); /* init PWM state */
switch (led->default_state) {
case LEDS_DEFSTATE_KEEP:
pwm_get_state(led_data->pwm, &led_data->pwmstate);
if (led_data->pwmstate.period)
break;
led->default_state = LEDS_DEFSTATE_OFF;
dev_warn(dev,
"failed to read period for %s, default to off",
led->name);
fallthrough;
default:
pwm_init_state(led_data->pwm, &led_data->pwmstate);
break;
}
/* set brightness */
switch (led->default_state) {
case LEDS_DEFSTATE_ON:
led_data->cdev.brightness = led->max_brightness;
break;
case LEDS_DEFSTATE_KEEP:
{
uint64_t brightness;
brightness = led->max_brightness;
brightness *= led_data->pwmstate.duty_cycle;
do_div(brightness, led_data->pwmstate.period);
led_data->cdev.brightness = brightness;
}
break;
}
ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data); ret = devm_led_classdev_register_ext(dev, &led_data->cdev, &init_data);
if (ret) { if (ret) {
...@@ -86,11 +119,13 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, ...@@ -86,11 +119,13 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
return ret; return ret;
} }
ret = led_pwm_set(&led_data->cdev, led_data->cdev.brightness); if (led->default_state != LEDS_DEFSTATE_KEEP) {
if (ret) { ret = led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
dev_err(dev, "failed to set led PWM value for %s: %d", if (ret) {
led->name, ret); dev_err(dev, "failed to set led PWM value for %s: %d",
return ret; led->name, ret);
return ret;
}
} }
priv->num_leds++; priv->num_leds++;
...@@ -120,6 +155,8 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) ...@@ -120,6 +155,8 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
fwnode_property_read_u32(fwnode, "max-brightness", fwnode_property_read_u32(fwnode, "max-brightness",
&led.max_brightness); &led.max_brightness);
led.default_state = led_init_default_state_get(fwnode);
ret = led_pwm_add(dev, priv, &led, fwnode); ret = led_pwm_add(dev, priv, &led, fwnode);
if (ret) if (ret)
goto err_child_out; goto err_child_out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment