Commit 3d44a6fd authored by Oliver Neukum's avatar Oliver Neukum Committed by Marcel Holtmann

Bluetooth: btusb: fix PM leak in error case of setup

If setup() fails a reference for runtime PM has already
been taken. Proper use of the error handling in btusb_open()is needed.
You cannot just return.

Fixes: ace31982 ("Bluetooth: btusb: Add setup callback for chip init on USB")
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 90bc72b1
...@@ -1200,7 +1200,7 @@ static int btusb_open(struct hci_dev *hdev) ...@@ -1200,7 +1200,7 @@ static int btusb_open(struct hci_dev *hdev)
if (data->setup_on_usb) { if (data->setup_on_usb) {
err = data->setup_on_usb(hdev); err = data->setup_on_usb(hdev);
if (err < 0) if (err < 0)
return err; goto setup_fail;
} }
data->intf->needs_remote_wakeup = 1; data->intf->needs_remote_wakeup = 1;
...@@ -1239,6 +1239,7 @@ static int btusb_open(struct hci_dev *hdev) ...@@ -1239,6 +1239,7 @@ static int btusb_open(struct hci_dev *hdev)
failed: failed:
clear_bit(BTUSB_INTR_RUNNING, &data->flags); clear_bit(BTUSB_INTR_RUNNING, &data->flags);
setup_fail:
usb_autopm_put_interface(data->intf); usb_autopm_put_interface(data->intf);
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment