Commit 3d57fa2a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bartosz Golaszewski

gpio: xgs-iproc: Drop if with an always false condition

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so chip is never NULL.

Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm
callbacks are called.

This is a preparation for making platform remove callbacks return void.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 1923433c
...@@ -281,11 +281,7 @@ static int iproc_gpio_probe(struct platform_device *pdev) ...@@ -281,11 +281,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
static int iproc_gpio_remove(struct platform_device *pdev) static int iproc_gpio_remove(struct platform_device *pdev)
{ {
struct iproc_gpio_chip *chip; struct iproc_gpio_chip *chip = platform_get_drvdata(pdev);
chip = platform_get_drvdata(pdev);
if (!chip)
return -ENODEV;
if (chip->intr) { if (chip->intr) {
u32 val; u32 val;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment