Commit 3e3a6935 authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Theodore Ts'o

ext4: tidy the BH loop in mext_page_mkuptodate()

This for loop is somewhat hard to read; turn it into a normal BH
do-while loop.
Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Link: https://patch.msgid.link/20240718223005.568869-4-willy@infradead.orgSigned-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent a40759fb
...@@ -187,9 +187,11 @@ static int mext_page_mkuptodate(struct folio *folio, size_t from, size_t to) ...@@ -187,9 +187,11 @@ static int mext_page_mkuptodate(struct folio *folio, size_t from, size_t to)
if (!head) if (!head)
head = create_empty_buffers(folio, blocksize, 0); head = create_empty_buffers(folio, blocksize, 0);
block = (sector_t)folio->index << (PAGE_SHIFT - inode->i_blkbits); block = folio_pos(folio) >> inode->i_blkbits;
for (bh = head, block_start = 0; bh != head || !block_start; block_end = 0;
block++, block_start = block_end, bh = bh->b_this_page) { bh = head;
do {
block_start = block_end;
block_end = block_start + blocksize; block_end = block_start + blocksize;
if (block_end <= from || block_start >= to) { if (block_end <= from || block_start >= to) {
if (!buffer_uptodate(bh)) if (!buffer_uptodate(bh))
...@@ -215,7 +217,8 @@ static int mext_page_mkuptodate(struct folio *folio, size_t from, size_t to) ...@@ -215,7 +217,8 @@ static int mext_page_mkuptodate(struct folio *folio, size_t from, size_t to)
} }
ext4_read_bh_nowait(bh, 0, NULL); ext4_read_bh_nowait(bh, 0, NULL);
nr++; nr++;
} } while (block++, (bh = bh->b_this_page) != head);
/* No io required */ /* No io required */
if (!nr) if (!nr)
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment