Commit 3e42fe5c authored by Georgi Djakov's avatar Georgi Djakov Committed by Greg Kroah-Hartman

interconnect: qcom: msm8974: Walk the list safely on node removal

As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().

Fixes: 4e60a956 ("interconnect: qcom: add msm8974 driver")
Reported-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarGeorgi Djakov <georgi.djakov@linaro.org>
Link: https://lore.kernel.org/r/20191212075332.16202-5-georgi.djakov@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f39488ea
...@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev) ...@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
struct icc_onecell_data *data; struct icc_onecell_data *data;
struct icc_provider *provider; struct icc_provider *provider;
struct icc_node *node; struct icc_node *node, *tmp;
size_t num_nodes, i; size_t num_nodes, i;
int ret; int ret;
...@@ -732,7 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev) ...@@ -732,7 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
return 0; return 0;
err_del_icc: err_del_icc:
list_for_each_entry(node, &provider->nodes, node_list) { list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
icc_node_del(node); icc_node_del(node);
icc_node_destroy(node->id); icc_node_destroy(node->id);
} }
...@@ -748,9 +748,9 @@ static int msm8974_icc_remove(struct platform_device *pdev) ...@@ -748,9 +748,9 @@ static int msm8974_icc_remove(struct platform_device *pdev)
{ {
struct msm8974_icc_provider *qp = platform_get_drvdata(pdev); struct msm8974_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider; struct icc_provider *provider = &qp->provider;
struct icc_node *n; struct icc_node *n, *tmp;
list_for_each_entry(n, &provider->nodes, node_list) { list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n); icc_node_del(n);
icc_node_destroy(n->id); icc_node_destroy(n->id);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment