Commit 3fe7034e authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Greg Kroah-Hartman

staging: i4l: icn: do not use return as a function

return is not a function so no need to use the parenthesis.
Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e9c43a75
...@@ -1245,7 +1245,7 @@ icn_command(isdn_ctrl *c, icn_card *card) ...@@ -1245,7 +1245,7 @@ icn_command(isdn_ctrl *c, icn_card *card)
dev.firstload = 0; dev.firstload = 0;
} }
icn_stopcard(card); icn_stopcard(card);
return (icn_loadboot(arg, card)); return icn_loadboot(arg, card);
case ICN_IOCTL_LOADPROTO: case ICN_IOCTL_LOADPROTO:
icn_stopcard(card); icn_stopcard(card);
if ((i = (icn_loadproto(arg, card)))) if ((i = (icn_loadproto(arg, card))))
...@@ -1261,7 +1261,7 @@ icn_command(isdn_ctrl *c, icn_card *card) ...@@ -1261,7 +1261,7 @@ icn_command(isdn_ctrl *c, icn_card *card)
arg, arg,
sizeof(cdef))) sizeof(cdef)))
return -EFAULT; return -EFAULT;
return (icn_addcard(cdef.port, cdef.id1, cdef.id2)); return icn_addcard(cdef.port, cdef.id1, cdef.id2);
break; break;
case ICN_IOCTL_LEASEDCFG: case ICN_IOCTL_LEASEDCFG:
if (a) { if (a) {
...@@ -1457,7 +1457,7 @@ if_command(isdn_ctrl *c) ...@@ -1457,7 +1457,7 @@ if_command(isdn_ctrl *c)
icn_card *card = icn_findcard(c->driver); icn_card *card = icn_findcard(c->driver);
if (card) if (card)
return (icn_command(c, card)); return icn_command(c, card);
printk(KERN_ERR printk(KERN_ERR
"icn: if_command %d called with invalid driverId %d!\n", "icn: if_command %d called with invalid driverId %d!\n",
c->command, c->driver); c->command, c->driver);
...@@ -1472,7 +1472,7 @@ if_writecmd(const u_char __user *buf, int len, int id, int channel) ...@@ -1472,7 +1472,7 @@ if_writecmd(const u_char __user *buf, int len, int id, int channel)
if (card) { if (card) {
if (!(card->flags & ICN_FLAGS_RUNNING)) if (!(card->flags & ICN_FLAGS_RUNNING))
return -ENODEV; return -ENODEV;
return (icn_writecmd(buf, len, 1, card)); return icn_writecmd(buf, len, 1, card);
} }
printk(KERN_ERR printk(KERN_ERR
"icn: if_writecmd called with invalid driverId!\n"); "icn: if_writecmd called with invalid driverId!\n");
...@@ -1487,7 +1487,7 @@ if_readstatus(u_char __user *buf, int len, int id, int channel) ...@@ -1487,7 +1487,7 @@ if_readstatus(u_char __user *buf, int len, int id, int channel)
if (card) { if (card) {
if (!(card->flags & ICN_FLAGS_RUNNING)) if (!(card->flags & ICN_FLAGS_RUNNING))
return -ENODEV; return -ENODEV;
return (icn_readstatus(buf, len, card)); return icn_readstatus(buf, len, card);
} }
printk(KERN_ERR printk(KERN_ERR
"icn: if_readstatus called with invalid driverId!\n"); "icn: if_readstatus called with invalid driverId!\n");
...@@ -1502,7 +1502,7 @@ if_sendbuf(int id, int channel, int ack, struct sk_buff *skb) ...@@ -1502,7 +1502,7 @@ if_sendbuf(int id, int channel, int ack, struct sk_buff *skb)
if (card) { if (card) {
if (!(card->flags & ICN_FLAGS_RUNNING)) if (!(card->flags & ICN_FLAGS_RUNNING))
return -ENODEV; return -ENODEV;
return (icn_sendbuf(channel, ack, skb, card)); return icn_sendbuf(channel, ack, skb, card);
} }
printk(KERN_ERR printk(KERN_ERR
"icn: if_sendbuf called with invalid driverId!\n"); "icn: if_sendbuf called with invalid driverId!\n");
...@@ -1616,7 +1616,7 @@ icn_setup(char *line) ...@@ -1616,7 +1616,7 @@ icn_setup(char *line)
icn_id2 = sid2; icn_id2 = sid2;
} }
} }
return (1); return 1;
} }
__setup("icn=", icn_setup); __setup("icn=", icn_setup);
#endif /* MODULE */ #endif /* MODULE */
...@@ -1643,7 +1643,7 @@ static int __init icn_init(void) ...@@ -1643,7 +1643,7 @@ static int __init icn_init(void)
strcpy(rev, " ??? "); strcpy(rev, " ??? ");
printk(KERN_NOTICE "ICN-ISDN-driver Rev%smem=0x%08lx\n", rev, printk(KERN_NOTICE "ICN-ISDN-driver Rev%smem=0x%08lx\n", rev,
dev.memaddr); dev.memaddr);
return (icn_addcard(portbase, icn_id, icn_id2)); return icn_addcard(portbase, icn_id, icn_id2);
} }
static void __exit icn_exit(void) static void __exit icn_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment