Commit 3fea924a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

media: seco-cec: fix building with RC_CORE=m

commit 63604a14 upstream.

I previously added an RC_CORE dependency here, but missed the corner
case of CONFIG_VIDEO_SECO_CEC=y with CONFIG_RC_CORE=m, which still
causes a link error:

drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_probe':
seco-cec.c:(.text+0x1b8): undefined reference to `devm_rc_allocate_device'
seco-cec.c:(.text+0x2e8): undefined reference to `devm_rc_register_device'
drivers/media/platform/seco-cec/seco-cec.o: In function `secocec_irq_handler':
seco-cec.c:(.text+0xa2c): undefined reference to `rc_keydown'

Refine the dependency to disallow building the RC subdriver in this case.
This is the same logic we apply in other drivers like it.

Fixes: f27dd0ad ("media: seco-cec: fix RC_CORE dependency")

Cc: <stable@vger.kernel.org> # 5.1
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5090537b
...@@ -649,7 +649,7 @@ config VIDEO_SECO_CEC ...@@ -649,7 +649,7 @@ config VIDEO_SECO_CEC
config VIDEO_SECO_RC config VIDEO_SECO_RC
bool "SECO Boards IR RC5 support" bool "SECO Boards IR RC5 support"
depends on VIDEO_SECO_CEC depends on VIDEO_SECO_CEC
depends on RC_CORE depends on RC_CORE=y || RC_CORE = VIDEO_SECO_CEC
help help
If you say yes here you will get support for the If you say yes here you will get support for the
SECO Boards Consumer-IR in seco-cec driver. SECO Boards Consumer-IR in seco-cec driver.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment