Commit 3ff81013 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

Staging: use llseek in all file operations

These could not be detected by the semantic patch.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
parent af6d2b2a
...@@ -63,13 +63,6 @@ DEFINE_SIMPLE_ATTRIBUTE( ...@@ -63,13 +63,6 @@ DEFINE_SIMPLE_ATTRIBUTE(
"%llx\n"); "%llx\n");
static int mdp4_debugfs_open(struct inode *inode, struct file *file)
{
/* non-seekable */
file->f_mode &= ~(FMODE_LSEEK | FMODE_PREAD | FMODE_PWRITE);
return 0;
}
static int mdp4_debugfs_release(struct inode *inode, struct file *file) static int mdp4_debugfs_release(struct inode *inode, struct file *file)
{ {
return 0; return 0;
...@@ -144,10 +137,11 @@ static ssize_t mdp4_debugfs_read( ...@@ -144,10 +137,11 @@ static ssize_t mdp4_debugfs_read(
} }
static const struct file_operations mdp4_debugfs_fops = { static const struct file_operations mdp4_debugfs_fops = {
.open = mdp4_debugfs_open, .open = nonseekable_open,
.release = mdp4_debugfs_release, .release = mdp4_debugfs_release,
.read = mdp4_debugfs_read, .read = mdp4_debugfs_read,
.write = mdp4_debugfs_write, .write = mdp4_debugfs_write,
.llseek = no_llseek,
}; };
int mdp4_debugfs_init(void) int mdp4_debugfs_init(void)
......
...@@ -1356,7 +1356,7 @@ static int lcd_open(struct inode *inode, struct file *file) ...@@ -1356,7 +1356,7 @@ static int lcd_open(struct inode *inode, struct file *file)
lcd_must_clear = 0; lcd_must_clear = 0;
} }
lcd_open_cnt++; lcd_open_cnt++;
return 0; return nonseekable_open(inode, file);
} }
static int lcd_release(struct inode *inode, struct file *file) static int lcd_release(struct inode *inode, struct file *file)
...@@ -1369,6 +1369,7 @@ static const struct file_operations lcd_fops = { ...@@ -1369,6 +1369,7 @@ static const struct file_operations lcd_fops = {
.write = lcd_write, .write = lcd_write,
.open = lcd_open, .open = lcd_open,
.release = lcd_release, .release = lcd_release,
.llseek = no_llseek,
}; };
static struct miscdevice lcd_dev = { static struct miscdevice lcd_dev = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment