Commit 40989cf3 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: arche-apb: Drop unnecessary checks

wake_detect_gpio and resetn_gpio are guaranteed to be valid in
apb_ctrl_cleanup() and irq-handler, no need to check for their validity.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarVaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent d258432f
...@@ -94,10 +94,6 @@ static irqreturn_t apb_ctrl_wake_detect_irq(int irq, void *devid) ...@@ -94,10 +94,6 @@ static irqreturn_t apb_ctrl_wake_detect_irq(int irq, void *devid)
* signals, especially when we start using GPIOs over slow * signals, especially when we start using GPIOs over slow
* buses like I2C. * buses like I2C.
*/ */
if (!gpio_is_valid(apb->wake_detect_gpio) &&
!gpio_is_valid(apb->resetn_gpio))
return IRQ_HANDLED; /* Should it be IRQ_NONE ?? */
spin_lock_irqsave(&apb->lock, flags); spin_lock_irqsave(&apb->lock, flags);
if (apb->state != APB_STATE_ACTIVE) { if (apb->state != APB_STATE_ACTIVE) {
...@@ -293,9 +289,7 @@ static void apb_ctrl_cleanup(struct arche_apb_ctrl_drvdata *apb) ...@@ -293,9 +289,7 @@ static void apb_ctrl_cleanup(struct arche_apb_ctrl_drvdata *apb)
spin_lock_irqsave(&apb->lock, flags); spin_lock_irqsave(&apb->lock, flags);
/* As part of exit, put APB back in reset state */ /* As part of exit, put APB back in reset state */
if (gpio_is_valid(apb->resetn_gpio)) gpio_set_value(apb->resetn_gpio, 0);
gpio_set_value(apb->resetn_gpio, 0);
apb->state = APB_STATE_OFF; apb->state = APB_STATE_OFF;
spin_unlock_irqrestore(&apb->lock, flags); spin_unlock_irqrestore(&apb->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment