Commit 40efb09a authored by Navid Emamdoost's avatar Navid Emamdoost Committed by Thomas Hellstrom

drm/vmwgfx: prevent memory leak in vmw_cmdbuf_res_add

In vmw_cmdbuf_res_add if drm_ht_insert_item fails the allocated memory
for cres should be released.

Fixes: 18e4a466 ("drm/vmwgfx: Fix compat shader namespace")
Signed-off-by: default avatarNavid Emamdoost <navid.emamdoost@gmail.com>
Reviewed-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: default avatarThomas Hellstrom <thellstrom@vmware.com>
parent 0d4c19f9
...@@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man, ...@@ -209,8 +209,10 @@ int vmw_cmdbuf_res_add(struct vmw_cmdbuf_res_manager *man,
cres->hash.key = user_key | (res_type << 24); cres->hash.key = user_key | (res_type << 24);
ret = drm_ht_insert_item(&man->resources, &cres->hash); ret = drm_ht_insert_item(&man->resources, &cres->hash);
if (unlikely(ret != 0)) if (unlikely(ret != 0)) {
kfree(cres);
goto out_invalid_key; goto out_invalid_key;
}
cres->state = VMW_CMDBUF_RES_ADD; cres->state = VMW_CMDBUF_RES_ADD;
cres->res = vmw_resource_reference(res); cres->res = vmw_resource_reference(res);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment