Commit 40f6d1d9 authored by Andrew Lunn's avatar Andrew Lunn Committed by Jakub Kicinski

drivers: net: smc911x: Fix set but unused status because of DBG macro

drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_timeout’:
drivers/net/ethernet/smsc/smc911x.c:1251:6: warning: variable ‘status’ set but not used [-Wunused-but-set-variable]
 1251 |  int status, mask;

The status is read in order to print it via the DBG macro. However,
due to the way DBG is disabled, the compiler never sees it being used.

Change the DBG macro to actually make use of the passed parameters,
and the leave the optimiser to remove the unwanted code inside the
while (0).
Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6015e6f2
...@@ -102,7 +102,10 @@ MODULE_ALIAS("platform:smc911x"); ...@@ -102,7 +102,10 @@ MODULE_ALIAS("platform:smc911x");
#define PRINTK(dev, args...) netdev_info(dev, args) #define PRINTK(dev, args...) netdev_info(dev, args)
#else #else
#define DBG(n, dev, args...) do { } while (0) #define DBG(n, dev, args...) \
while (0) { \
netdev_dbg(dev, args); \
}
#define PRINTK(dev, args...) netdev_dbg(dev, args) #define PRINTK(dev, args...) netdev_dbg(dev, args)
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment