Commit 41038bf2 authored by Paul Burton's avatar Paul Burton Committed by Greg Kroah-Hartman

MIPS: Fix ISA virt/bus conversion for non-zero PHYS_OFFSET

[ Upstream commit 0494d7ff ]

isa_virt_to_bus() & isa_bus_to_virt() claim to treat ISA bus addresses
as being identical to physical addresses, but they fail to do so in the
presence of a non-zero PHYS_OFFSET.

Correct this by having them use virt_to_phys() & phys_to_virt(), which
consolidates the calculations to one place & ensures that ISA bus
addresses do indeed match physical addresses.
Signed-off-by: default avatarPaul Burton <paul.burton@mips.com>
Patchwork: https://patchwork.linux-mips.org/patch/20047/
Cc: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: Vladimir Kondratiev <vladimir.kondratiev@intel.com>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2071bd1c
...@@ -141,14 +141,14 @@ static inline void * phys_to_virt(unsigned long address) ...@@ -141,14 +141,14 @@ static inline void * phys_to_virt(unsigned long address)
/* /*
* ISA I/O bus memory addresses are 1:1 with the physical address. * ISA I/O bus memory addresses are 1:1 with the physical address.
*/ */
static inline unsigned long isa_virt_to_bus(volatile void * address) static inline unsigned long isa_virt_to_bus(volatile void *address)
{ {
return (unsigned long)address - PAGE_OFFSET; return virt_to_phys(address);
} }
static inline void * isa_bus_to_virt(unsigned long address) static inline void *isa_bus_to_virt(unsigned long address)
{ {
return (void *)(address + PAGE_OFFSET); return phys_to_virt(address);
} }
#define isa_page_to_bus page_to_phys #define isa_page_to_bus page_to_phys
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment