Commit 419c2046 authored by Jiri Slaby's avatar Jiri Slaby Committed by David S. Miller

NET: pch, fix use after free

Stanse found that pch_gbe_xmit_frame uses skb after it is freed. Fix
that.
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 34d101dd
...@@ -1847,9 +1847,9 @@ static int pch_gbe_xmit_frame(struct sk_buff *skb, struct net_device *netdev) ...@@ -1847,9 +1847,9 @@ static int pch_gbe_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
unsigned long flags; unsigned long flags;
if (unlikely(skb->len > (adapter->hw.mac.max_frame_size - 4))) { if (unlikely(skb->len > (adapter->hw.mac.max_frame_size - 4))) {
dev_kfree_skb_any(skb);
pr_err("Transfer length Error: skb len: %d > max: %d\n", pr_err("Transfer length Error: skb len: %d > max: %d\n",
skb->len, adapter->hw.mac.max_frame_size); skb->len, adapter->hw.mac.max_frame_size);
dev_kfree_skb_any(skb);
adapter->stats.tx_length_errors++; adapter->stats.tx_length_errors++;
return NETDEV_TX_OK; return NETDEV_TX_OK;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment