Commit 42815f8a authored by Hou Tao's avatar Hou Tao Committed by Miklos Szeredi

fuse: set FR_PENDING atomically in fuse_resend()

When fuse_resend() moves the requests from processing lists to pending
list, it uses __set_bit() to set FR_PENDING bit in req->flags.

Using __set_bit() is not safe, because other functions may update
req->flags concurrently (e.g., request_wait_answer() may call
set_bit(FR_INTERRUPTED, &flags)).

Fix it by using set_bit() instead.

Fixes: 760eac73 ("fuse: Introduce a new notification type for resend pending requests")
Signed-off-by: default avatarHou Tao <houtao1@huawei.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 9fe2a036
......@@ -1813,7 +1813,7 @@ static void fuse_resend(struct fuse_conn *fc)
spin_unlock(&fc->lock);
list_for_each_entry_safe(req, next, &to_queue, list) {
__set_bit(FR_PENDING, &req->flags);
set_bit(FR_PENDING, &req->flags);
/* mark the request as resend request */
req->in.h.unique |= FUSE_UNIQUE_RESEND;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment