Commit 42a2df3e authored by Dan Carpenter's avatar Dan Carpenter Committed by Casey Schaufler

Smack: prevent underflow in smk_set_cipso()

We have an upper bound on "maplevel" but forgot to check for negative
values.

Fixes: e114e473 ("Smack: Simplified Mandatory Access Control Kernel")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
parent a6bd4f6d
...@@ -884,7 +884,7 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, ...@@ -884,7 +884,7 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf,
} }
ret = sscanf(rule, "%d", &maplevel); ret = sscanf(rule, "%d", &maplevel);
if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL) if (ret != 1 || maplevel < 0 || maplevel > SMACK_CIPSO_MAXLEVEL)
goto out; goto out;
rule += SMK_DIGITLEN; rule += SMK_DIGITLEN;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment