staging: csr: remove func_enter macro

this macro is used for debugging purposes, it actually defined as if (unifi_debug >= 5) { printk("unifi => %s\n", __FUNCTION__); } which produces too many of those prints if the unifi_debug is >=5. remove these calls and the macro itself altogether Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

staging: csr: remove func_enter macro
this macro is used for debugging purposes, it actually defined as if (unifi_debug >= 5) { printk("unifi => %s\n", __FUNCTION__); } which produces too many of those prints if the unifi_debug is >=5. remove these calls and the macro itself altogether Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
438d2d13 · Devendra Naga · Greg Kroah-Hartman · cb1f6268 · 438d2d13 · 438d2d13
Commit 438d2d13 authored Oct 27, 2012 by Devendra Naga Committed by Greg Kroah-Hartman Oct 29, 2012
17 changed files
--- a/drivers/staging/csr/csr_wifi_hip_card_sdio.c
+++ b/drivers/staging/csr/csr_wifi_hip_card_sdio.c
@@ -70,8 +70,6 @@ card_t* unifi_alloc_card(CsrSdioFunction *sdio, void *ospriv)
    card_t *card;
    u32 i;
-    func_enter();
    card = kzalloc(sizeof(card_t), GFP_KERNEL);
    if (card == NULL)
@@ -171,7 +169,6 @@ CsrResult unifi_init_card(card_t *card, s32 led_mask)
 {
    CsrResult r;
-    func_enter();
    if (card == NULL)
    {
@@ -223,8 +220,6 @@ CsrResult unifi_init(card_t *card)
    CsrResult r;
    CsrResult csrResult;
-    func_enter();
    if (card == NULL)
    {
        func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE);
@@ -363,8 +358,6 @@ CsrResult unifi_download(card_t *card, s32 led_mask)
    CsrResult r;
    void *dlpriv;
-    func_enter();
    if (card == NULL)
    {
        func_exit_r(CSR_WIFI_HIP_RESULT_INVALID_VALUE);
@@ -425,8 +418,6 @@ static CsrResult unifi_hip_init(card_t *card)
    CsrResult r;
    CsrResult csrResult;
-    func_enter();
    r = card_hw_init(card);
    if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE)
    {
@@ -609,8 +600,6 @@ static CsrResult card_hw_init(card_t *card)
    s16 search_4slut_again;
    CsrResult csrResult;
-    func_enter();
    /*
     * The device revision from the TPLMID_MANF and TPLMID_CARD fields
     * of the CIS are available as
@@ -1004,8 +993,6 @@ static CsrResult card_wait_for_unifi_to_reset(card_t *card)
    u8 io_enable;
    CsrResult csrResult;
-    func_enter();
    r = CSR_RESULT_SUCCESS;
    for (i = 0; i < MAILBOX2_ATTEMPTS; i++)
    {
@@ -1136,8 +1123,6 @@ static CsrResult card_wait_for_unifi_to_disable(card_t *card)
    u8 io_enable;
    CsrResult csrResult;
-    func_enter();
    if (card->chip_id <= SDIO_CARD_ID_UNIFI_2)
    {
        unifi_error(card->ospriv,
@@ -1238,8 +1223,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr)
    u16 mbox0, mbox1;
    CsrResult r;
-    func_enter();
    /*
     * Wait for UniFi to initialise its data structures by polling
     * the SHARED_MAILBOX1 register.
@@ -1358,7 +1341,6 @@ CsrResult card_wait_for_firmware_to_start(card_t *card, u32 *paddr)
 */
 CsrResult unifi_capture_panic(card_t *card)
 {
-    func_enter();
    /* The firmware must have previously initialised to read the panic addresses
     * from the SLUT
@@ -1405,8 +1387,6 @@ static CsrResult card_access_panic(card_t *card)
    s32 i;
    CsrResult r, sr;
-    func_enter();
    /* A chip version of zero means that the version never got succesfully read
     * during reset. In this case give up because it will not be possible to
     * verify the chip version.
@@ -1536,8 +1516,6 @@ void unifi_read_panic(card_t *card)
    CsrResult r;
    u16 p_code, p_arg;
-    func_enter();
    /* The firmware must have previously initialised to read the panic addresses
     * from the SLUT
     */
@@ -1607,8 +1585,6 @@ static CsrResult card_allocate_memory_resources(card_t *card)
    s16 n, i, k, r;
    sdio_config_data_t *cfg_data;
-    func_enter();
    /* Reset any state carried forward from a previous life */
    card->fh_command_queue.q_rd_ptr = 0;
    card->fh_command_queue.q_wr_ptr = 0;
@@ -1781,7 +1757,6 @@ static void unifi_free_bulk_data(card_t *card, bulk_data_desc_t *bulk_data_slot)
 */
 static void card_free_memory_resources(card_t *card)
 {
-    func_enter();
    unifi_trace(card->ospriv, UDBG1, "Freeing card memory resources.\n");
@@ -1820,8 +1795,6 @@ static void card_init_soft_queues(card_t *card)
 {
    s16 i;
-    func_enter();
    unifi_trace(card->ospriv, UDBG1, "Initialising internal signal queues.\n");
    /* Reset any state carried forward from a previous life */
    card->fh_command_queue.q_rd_ptr = 0;
@@ -1858,7 +1831,6 @@ static void card_init_soft_queues(card_t *card)
 void unifi_cancel_pending_signals(card_t *card)
 {
    s16 i, n, r;
-    func_enter();
    unifi_trace(card->ospriv, UDBG1, "Canceling pending signals.\n");
@@ -1951,7 +1923,6 @@ void unifi_cancel_pending_signals(card_t *card)
 */
 void unifi_free_card(card_t *card)
 {
-    func_enter();
 #ifdef CSR_PRE_ALLOC_NET_DATA
    prealloc_netdata_free(card);
 #endif
@@ -1989,8 +1960,6 @@ static CsrResult card_init_slots(card_t *card)
    CsrResult r;
    u8 i;
-    func_enter();
    /* Allocate the buffers we need, only once. */
    if (card->memory_resources_allocated == 1)
    {
@@ -2153,8 +2122,6 @@ static void CardReassignDynamicReservation(card_t *card)
 {
    u8 i;
-    func_enter();
    unifi_trace(card->ospriv, UDBG5, "Packets Txed %d %d %d %d\n",
                card->dynamic_slot_data.packets_txed[0],
                card->dynamic_slot_data.packets_txed[1],
@@ -2206,8 +2173,6 @@ static void CardCheckDynamicReservation(card_t *card, unifi_TrafficQueue queue)
    q_t *sigq;
    u16 num_data_slots = card->config_data.num_fromhost_data_slots - UNIFI_RESERVED_COMMAND_SLOTS;
-    func_enter();
    /* Calculate the pending queue length */
    sigq = &card->fh_traffic_queue[queue];
    q_len = CSR_WIFI_HIP_Q_SLOTS_USED(sigq);
@@ -2336,8 +2301,6 @@ void CardClearFromHostDataSlot(card_t *card, const s16 slot)
    u8 queue = card->from_host_data[slot].queue;
    const void *os_data_ptr = card->from_host_data[slot].bd.os_data_ptr;
-    func_enter();
    if (card->from_host_data[slot].bd.data_length == 0)
    {
        unifi_warning(card->ospriv,
@@ -2457,8 +2420,6 @@ u16 CardGetFreeFromHostDataSlots(card_t *card)
 {
    u16 i, n = 0;
-    func_enter();
    /* First two slots reserved for MLME */
    for (i = 0; i < card->config_data.num_fromhost_data_slots; i++)
    {
@@ -2506,7 +2467,6 @@ u16 CardAreAllFromHostDataSlotsEmpty(card_t *card)
 static CsrResult unifi_identify_hw(card_t *card)
 {
-    func_enter();
    card->chip_id = card->sdio_if->sdioId.cardId;
    card->function = card->sdio_if->sdioId.sdioFunction;
@@ -2541,8 +2501,6 @@ static CsrResult unifi_prepare_hw(card_t *card)
    CsrResult csrResult;
    enum unifi_host_state old_state = card->host_state;
-    func_enter();
    r = unifi_identify_hw(card);
    if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE)
    {
@@ -2625,8 +2583,6 @@ static CsrResult unifi_read_chip_version(card_t *card)
    CsrResult r;
    u16 ver;
-    func_enter();
    gbl_chip_version = ChipHelper_GBL_CHIP_VERSION(card->helper);
    /* Try to read the chip version from register. */
@@ -2684,8 +2640,6 @@ static CsrResult unifi_reset_hardware(card_t *card)
    u16 new_block_size = UNIFI_IO_BLOCK_SIZE;
    CsrResult csrResult;
-    func_enter();
    /* Errors returned by unifi_prepare_hw() are not critical at this point */
    r = unifi_prepare_hw(card);
    if (r == CSR_WIFI_HIP_RESULT_NO_DEVICE)
@@ -2818,8 +2772,6 @@ static CsrResult card_reset_method_io_enable(card_t *card)
    CsrResult r;
    CsrResult csrResult;
-    func_enter();
    /*
     * This resets only function 1, so should be used in
     * preference to the method below (CSR_FUNC_EN)
@@ -2915,8 +2867,6 @@ static CsrResult card_reset_method_dbg_reset(card_t *card)
 {
    CsrResult r;
-    func_enter();
    /*
     * Prepare UniFi for h/w reset
     */
@@ -3008,8 +2958,6 @@ CsrResult unifi_card_hard_reset(card_t *card)
    const struct chip_helper_reset_values *init_data;
    u32 chunks;
-    func_enter();
    /* Clear cache of page registers */
    card->proc_select = (u32)(-1);
    card->dmem_page = (u32)(-1);
@@ -3097,8 +3045,6 @@ CsrResult CardGenInt(card_t *card)
 {
    CsrResult r;
-    func_enter();
    if (card->chip_id > SDIO_CARD_ID_UNIFI_2)
    {
        r = sdio_write_f0(card, SDIO_CSR_FROM_HOST_SCRATCH0,
@@ -3388,8 +3334,6 @@ CsrResult CardWriteBulkData(card_t *card, card_signal_t *csptr, unifi_TrafficQue
    bulk_data_desc_t *bulkdata = csptr->bulkdata;
    s16 h, nslots;
-    func_enter();
    /* Count the number of slots required */
    for (i = 0; i < UNIFI_MAX_DATA_REFERENCES; i++)
    {

--- a/drivers/staging/csr/csr_wifi_hip_download.c
+++ b/drivers/staging/csr/csr_wifi_hip_download.c
@@ -327,8 +327,6 @@ CsrResult unifi_dl_firmware(card_t *card, void *dlpriv)
    xbv1_t *fwinfo;
    CsrResult r;
-    func_enter();
    fwinfo = kmalloc(sizeof(xbv1_t), GFP_KERNEL);
    if (fwinfo == NULL)
    {
@@ -407,8 +405,6 @@ CsrResult unifi_dl_patch(card_t *card, void *dlpriv, u32 boot_ctrl)
    xbv1_t *fwinfo;
    CsrResult r;
-    func_enter();
    unifi_info(card->ospriv, "unifi_dl_patch %p %08x\n", dlpriv, boot_ctrl);
    fwinfo = kmalloc(sizeof(xbv1_t), GFP_KERNEL);

--- a/drivers/staging/csr/csr_wifi_hip_dump.c
+++ b/drivers/staging/csr/csr_wifi_hip_dump.c
@@ -104,8 +104,6 @@ CsrResult unifi_coredump_request_at_next_reset(card_t *card, s8 enable)
 {
    CsrResult r;
-    func_enter();
    if (enable)
    {
        unifi_trace(card->ospriv, UDBG2, "Mini-coredump requested after reset\n");
@@ -145,8 +143,6 @@ CsrResult unifi_coredump_handle_request(card_t *card)
 {
    CsrResult r = CSR_RESULT_SUCCESS;
-    func_enter();
    if (card == NULL)
    {
        r = CSR_WIFI_HIP_RESULT_INVALID_VALUE;
@@ -194,8 +190,6 @@ CsrResult unifi_coredump_capture(card_t *card, struct unifi_coredump_req *req)
    static u16 dump_seq_no = 1;
    u32 time_of_capture;
-    func_enter();
    if (card->dump_next_write == NULL)
    {
        r = CSR_RESULT_SUCCESS;
@@ -358,8 +352,6 @@ CsrResult unifi_coredump_get_value(card_t *card, struct unifi_coredump_req *req)
    s32 i = 0;
    coredump_buffer *find_dump = NULL;
-    func_enter();
    if (req == NULL || card == NULL)
    {
        r = CSR_WIFI_HIP_RESULT_INVALID_VALUE;
@@ -481,8 +473,6 @@ static CsrResult unifi_coredump_read_zone(card_t *card, u16 *zonebuf, const stru
 {
    CsrResult r;
-    func_enter();
    if (zonebuf == NULL || def == NULL)
    {
        r = CSR_WIFI_HIP_RESULT_INVALID_VALUE;
@@ -551,8 +541,6 @@ static CsrResult unifi_coredump_read_zones(card_t *card, coredump_buffer *dump_b
    CsrResult r = CSR_RESULT_SUCCESS;
    s32 i;
-    func_enter();
    /* Walk the table of coredump zone definitions and read them from the chip */
    for (i = 0;
         (i < HIP_CDUMP_NUM_ZONES) && (r == 0);
@@ -590,8 +578,6 @@ static CsrResult unifi_coredump_from_sdio(card_t *card, coredump_buffer *dump_bu
    CsrResult r;
    u32 sdio_addr;
-    func_enter();
    if (dump_buf == NULL)
    {
        r = CSR_WIFI_HIP_RESULT_INVALID_VALUE;
@@ -743,8 +729,6 @@ CsrResult unifi_coredump_init(card_t *card, u16 num_dump_buffers)
    u32 i = 0;
 #endif
-    func_enter();
    card->request_coredump_on_reset = 0;
    card->dump_next_write = NULL;
    card->dump_cur_read = NULL;
@@ -826,7 +810,6 @@ void unifi_coredump_free(card_t *card)
    s16 i = 0;
    s16 j;
-    func_enter();
    unifi_trace(ospriv, UDBG2, "Core dump de-configured\n");
    if (card->dump_buf == NULL)

--- a/drivers/staging/csr/drv.c
+++ b/drivers/staging/csr/drv.c
@@ -266,8 +266,6 @@ unifi_open(struct inode *inode, struct file *file)
    unifi_priv_t *priv;
    ul_client_t *udi_cli;
-    func_enter();
    devno = MINOR(inode->i_rdev) >> 1;
    /*
@@ -369,8 +367,6 @@ unifi_release(struct inode *inode, struct file *filp)
    int devno;
    unifi_priv_t *priv;
-    func_enter();
    priv = uf_find_instance(udi_cli->instance);
    if (!priv) {
        unifi_error(priv, "unifi_close: instance for device not found\n");
@@ -465,8 +461,6 @@ unifi_read(struct file *filp, char *p, size_t len, loff_t *poff)
    struct list_head *l;
    int msglen;
-    func_enter();
    priv = uf_find_instance(pcli->instance);
    if (!priv) {
        unifi_error(priv, "invalid priv\n");
@@ -654,8 +648,6 @@ udi_send_signal_raw(unifi_priv_t *priv, unsigned char *buf, int buflen)
    int bytecount;
    CsrResult csrResult;
-    func_enter();
    /*
     * The signal is the first thing in buf, the signal id is the
     * first 16 bits of the signal.
@@ -784,8 +776,6 @@ unifi_write(struct file *filp, const char *p, size_t len, loff_t *poff)
    bulk_data_param_t bulkdata;
    CsrResult csrResult;
-    func_enter();
    priv = uf_find_instance(pcli->instance);
    if (!priv) {
        unifi_error(priv, "invalid priv\n");
@@ -1657,8 +1647,6 @@ unifi_poll(struct file *filp, poll_table *wait)
    unsigned int mask = 0;
    int ready;
-    func_enter();
    ready = !list_empty(&pcli->udi_log);
    poll_wait(filp, &pcli->udi_wq, wait);
@@ -1784,8 +1772,6 @@ udi_log_event(ul_client_t *pcli,
    unsigned long n_1000;
 #endif
-    func_enter();
    /* Just a sanity check */
    if ((signal == NULL) || (signal_len <= 0)) {
        return;
@@ -1921,8 +1907,6 @@ uf_sme_queue_message(unifi_priv_t *priv, u8 *buffer, int length)
    udi_msg_t *msgptr;
    u8 *p;
-    func_enter();
    /* Just a sanity check */
    if ((buffer == NULL) || (length <= 0)) {
        return -EINVAL;

--- a/drivers/staging/csr/firmware.c
+++ b/drivers/staging/csr/firmware.c
@@ -62,8 +62,6 @@ unifi_fw_read_start(void *ospriv, s8 is_fw, const card_info_t *info)
    unifi_priv_t *priv = (unifi_priv_t*)ospriv;
    CSR_UNUSED(info);
-    func_enter();
    if (is_fw == UNIFI_FW_STA) {
        /* F/w may have been released after a previous successful download. */
        if (priv->fw_sta.dl_data == NULL) {
@@ -105,7 +103,6 @@ unifi_fw_read_stop(void *ospriv, void *dlpriv)
 {
    unifi_priv_t *priv = (unifi_priv_t*)ospriv;
    struct dlpriv *dl_struct = (struct dlpriv *)dlpriv;
-    func_enter();
    if (dl_struct != NULL) {
        if (dl_struct->dl_data != NULL) {
@@ -143,7 +140,6 @@ void *
 unifi_fw_open_buffer(void *ospriv, void *fwbuf, u32 len)
 {
    unifi_priv_t *priv = (unifi_priv_t*)ospriv;
-    func_enter();
    if (fwbuf == NULL) {
        func_exit();

--- a/drivers/staging/csr/io.c
+++ b/drivers/staging/csr/io.c
@@ -85,7 +85,6 @@ static int uf_read_proc(char *page, char **start, off_t offset, int count,
 static CsrResult signal_buffer_init(unifi_priv_t * priv, int size)
 {
    int i;
-    func_enter();
    priv->rxSignalBuffer.writePointer =
    priv->rxSignalBuffer.readPointer = 0;
@@ -264,8 +263,6 @@ register_unifi_sdio(CsrSdioFunction *sdio_dev, int bus_id, struct device *dev)
    int r = -1;
    CsrResult csrResult;
-    func_enter();
    if ((bus_id < 0) || (bus_id >= MAX_UNIFI_DEVS)) {
        unifi_error(priv, "register_unifi_sdio: invalid device %d\n",
                bus_id);
@@ -472,7 +469,6 @@ if (log_hip_signals)
 static void
 ask_unifi_sdio_cleanup(unifi_priv_t *priv)
 {
-    func_enter();
    /*
     * Now clear the flag that says the old instance is in use.
@@ -510,8 +506,6 @@ cleanup_unifi_sdio(unifi_priv_t *priv)
    int i;
    static const CsrWifiMacAddress broadcast_address = {{0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF}};
-    func_enter();
    /* Remove the device nodes */
    uf_destroy_device_nodes(priv);

--- a/drivers/staging/csr/mlme.c
+++ b/drivers/staging/csr/mlme.c
@@ -154,8 +154,6 @@ unifi_mlme_blocking_request(unifi_priv_t *priv, ul_client_t *pcli,
 {
    int r;
-    func_enter();
    if (sig->SignalPrimitiveHeader.SignalId == 0) {
        unifi_error(priv, "unifi_mlme_blocking_request: Invalid Signal Id (0x%x)\n",
                    sig->SignalPrimitiveHeader.SignalId);

--- a/drivers/staging/csr/monitor.c
+++ b/drivers/staging/csr/monitor.c
@@ -121,8 +121,6 @@ netrx_radiotap(unifi_priv_t *priv,
    struct unifi_rx_radiotap_header *unifi_rt;
    int signal, noise, snr;
-    func_enter();
    if (ind_data_len <= 0) {
        unifi_error(priv, "Invalid length in CSR_MA_SNIFFDATA_INDICATION.\n");
        return;
@@ -255,8 +253,6 @@ netrx_prism(unifi_priv_t *priv,
    } *avs;
    int signal, noise, snr;
-    func_enter();
    if (ind_data_len <= 0) {
        unifi_error(priv, "Invalid length in CSR_MA_SNIFFDATA_INDICATION.\n");
        return;
@@ -350,8 +346,6 @@ ma_sniffdata_ind(void *ospriv,
    struct net_device *dev = priv->netdev;
    struct sk_buff *skb = (struct sk_buff*)bulkdata->d[0].os_net_buf_ptr;
-    func_enter();
    if (bulkdata->d[0].data_length == 0) {
        unifi_warning(priv, "rx: MA-SNIFFDATA indication with zero bulk data\n");
        func_exit();

--- a/drivers/staging/csr/netdev.c
+++ b/drivers/staging/csr/netdev.c
@@ -477,8 +477,6 @@ uf_free_netdevice(unifi_priv_t *priv)
    int i;
    unsigned long flags;
-    func_enter();
    unifi_trace(priv, UDBG1, "uf_free_netdevice\n");
    if (!priv) {
@@ -577,8 +575,6 @@ uf_net_open(struct net_device *dev)
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
-    func_enter();
    /* If we haven't finished UniFi initialisation, we can't start */
    if (priv->init_progress != UNIFI_INIT_COMPLETED) {
        unifi_warning(priv, "%s: unifi not ready, failing net_open\n", __FUNCTION__);
@@ -626,8 +622,6 @@ uf_net_stop(struct net_device *dev)
    netInterface_priv_t *interfacePriv = (netInterface_priv_t*)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
-    func_enter();
    /* Stop sniffing if in Monitor mode */
    if (priv->wext_conf.mode == IW_MODE_MONITOR) {
        if (priv->card) {
@@ -638,8 +632,6 @@ uf_net_stop(struct net_device *dev)
            }
        }
    }
-#else
-    func_enter();
 #endif
    netif_tx_stop_all_queues(dev);
@@ -674,7 +666,6 @@ static CSR_PRIORITY uf_get_packet_priority(unifi_priv_t *priv, netInterface_priv
 {
    CSR_PRIORITY priority = CSR_CONTENTION;
-    func_enter();
    priority = (CSR_PRIORITY) (skb->priority >> 5);
    if (priority == CSR_QOS_UP0) { /* 0 */
@@ -749,8 +740,6 @@ get_packet_priority(unifi_priv_t *priv, struct sk_buff *skb, const struct ethhdr
    u8 interfaceMode = interfacePriv->interfaceMode;
-    func_enter();
    /* Priority Mapping for all the Modes */
    switch(interfaceMode)
    {
@@ -815,8 +804,6 @@ uf_net_select_queue(struct net_device *dev, struct sk_buff *skb)
    int proto;
    CSR_PRIORITY priority;
-    func_enter();
    memcpy(&ehdr, skb->data, ETH_HLEN);
    proto = ntohs(ehdr.h_proto);
@@ -1759,8 +1746,6 @@ uf_net_xmit(struct sk_buff *skb, struct net_device *dev)
    CSR_PRIORITY priority;
    CsrWifiRouterCtrlPortAction port_action;
-    func_enter();
    unifi_trace(priv, UDBG5, "unifi_net_xmit: skb = %x\n", skb);
    memcpy(&ehdr, skb->data, ETH_HLEN);
@@ -1876,7 +1861,6 @@ unifi_pause_xmit(void *ospriv, unifi_TrafficQueue queue)
    unifi_priv_t *priv = ospriv;
    int i; /* used as a loop counter */
-    func_enter();
    unifi_trace(priv, UDBG2, "Stopping queue %d\n", queue);
    for(i=0;i<CSR_WIFI_NUM_INTERFACES;i++)
@@ -1906,7 +1890,6 @@ unifi_restart_xmit(void *ospriv, unifi_TrafficQueue queue)
    unifi_priv_t *priv = ospriv;
    int i=0; /* used as a loop counter */
-    func_enter();
    unifi_trace(priv, UDBG2, "Waking queue %d\n", queue);
    for(i=0;i<CSR_WIFI_NUM_INTERFACES;i++)
@@ -2177,8 +2160,6 @@ unifi_rx(unifi_priv_t *priv, CSR_SIGNAL *signal, bulk_data_param_t *bulkdata)
    netInterface_priv_t *interfacePriv;
    struct ethhdr ehdr;
-    func_enter();
    interfaceTag = (pkt_ind->VirtualInterfaceIdentifier & 0xff);
    interfacePriv = priv->interfacePriv[interfaceTag];
@@ -2455,7 +2436,6 @@ static void process_ma_packet_cfm(unifi_priv_t *priv, CSR_SIGNAL *signal, bulk_d
    const CSR_MA_PACKET_CONFIRM *pkt_cfm = &signal->u.MaPacketConfirm;
    netInterface_priv_t *interfacePriv;
-    func_enter();
    interfaceTag = (pkt_cfm->VirtualInterfaceIdentifier & 0xff);
    interfacePriv = priv->interfacePriv[interfaceTag];
@@ -2527,8 +2507,6 @@ static void process_ma_packet_ind(unifi_priv_t *priv, CSR_SIGNAL *signal, bulk_d
 #endif
-    func_enter();
    interfaceTag = (pkt_ind->VirtualInterfaceIdentifier & 0xff);
    interfacePriv = priv->interfacePriv[interfaceTag];
@@ -2835,8 +2813,6 @@ netdev_mlme_event_handler(ul_client_t *pcli, const u8 *sig_packed, int sig_len,
    int id, r;
    bulk_data_param_t bulkdata;
-    func_enter();
    /* Just a sanity check */
    if (sig_packed == NULL) {
        return;
@@ -3330,8 +3306,6 @@ static void process_ma_packet_error_ind(unifi_priv_t *priv, CSR_SIGNAL *signal,
    CSR_PRIORITY        UserPriority;
    CSR_SEQUENCE_NUMBER sn;
-    func_enter();
    interfaceTag = (pkt_err_ind->VirtualInterfaceIdentifier & 0xff);

--- a/drivers/staging/csr/sdio_mmc.c
+++ b/drivers/staging/csr/sdio_mmc.c
@@ -540,8 +540,6 @@ CsrSdioFunctionEnable(CsrSdioFunction *function)
    struct sdio_func *func = (struct sdio_func *)function->priv;
    int err;
-    func_enter();
    /* Enable UniFi function 1 (the 802.11 part). */
    _sdio_claim_host(func);
    err = sdio_enable_func(func);
@@ -574,8 +572,6 @@ CsrSdioFunctionDisable(CsrSdioFunction *function)
    struct sdio_func *func = (struct sdio_func *)function->priv;
    int err;
-    func_enter();
    /* Disable UniFi function 1 (the 802.11 part). */
    _sdio_claim_host(func);
    err = sdio_disable_func(func);
@@ -1033,8 +1029,6 @@ uf_glue_sdio_probe(struct sdio_func *func,
    int instance;
    CsrSdioFunction *sdio_ctx;
-    func_enter();
    /* First of all claim the SDIO driver */
    sdio_claim_host(func);
@@ -1130,8 +1124,6 @@ uf_glue_sdio_remove(struct sdio_func *func)
        return;
    }
-    func_enter();
    unifi_info(NULL, "UniFi card removed\n");
    /* Clean up the SDIO function driver */
@@ -1182,8 +1174,6 @@ MODULE_DEVICE_TABLE(sdio, unifi_ids);
 static int
 uf_glue_sdio_suspend(struct device *dev)
 {
-    func_enter();
    unifi_trace(NULL, UDBG1, "uf_glue_sdio_suspend");
    func_exit();
@@ -1207,8 +1197,6 @@ uf_glue_sdio_suspend(struct device *dev)
 static int
 uf_glue_sdio_resume(struct device *dev)
 {
-    func_enter();
    unifi_trace(NULL, UDBG1, "uf_glue_sdio_resume");
 #ifdef ANDROID_BUILD

--- a/drivers/staging/csr/sme_native.c
+++ b/drivers/staging/csr/sme_native.c
@@ -21,8 +21,6 @@ static const unsigned char wildcard_address[ETH_ALEN] = {0x00, 0x00, 0x00, 0x00,
 int
 uf_sme_init(unifi_priv_t *priv)
 {
-    func_enter();
    sema_init(&priv->mlme_blocking_mutex, 1);
 #ifdef CSR_SUPPORT_WEXT
@@ -46,8 +44,6 @@ void
 uf_sme_deinit(unifi_priv_t *priv)
 {
-    func_enter();
    /* Free memory allocated for the scan table */
 /*    unifi_clear_scan_table(priv); */
@@ -221,8 +217,6 @@ sme_native_log_event(ul_client_t *pcli,
    CSR_SIGNAL signal;
    ul_client_t *client = pcli;
-    func_enter();
    if (client == NULL) {
        unifi_error(NULL, "sme_native_log_event: client has exited\n");
        return;
@@ -460,8 +454,6 @@ sme_native_mlme_event_handler(ul_client_t *pcli,
    unifi_priv_t *priv = uf_find_instance(pcli->instance);
    int id, r;
-    func_enter();
    /* Just a sanity check */
    if ((sig_packed == NULL) || (sig_len <= 0)) {
        return;
@@ -573,8 +565,6 @@ unifi_reset_state(unifi_priv_t *priv, unsigned char *macaddr,
 {
    int r = 0;
-    func_enter();
 #ifdef CSR_SUPPORT_WEXT
    /* The reset clears any 802.11 association. */
    priv->wext_conf.flag_associated = 0;

--- a/drivers/staging/csr/sme_sys.c
+++ b/drivers/staging/csr/sme_sys.c
@@ -412,8 +412,6 @@ uf_send_gratuitous_arp(unifi_priv_t *priv, u16 interfaceTag)
                                         0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
                                         0xc0, 0xa8, 0x00, 0x02};
-    func_enter();
    csrResult = unifi_net_data_malloc(priv, &bulkdata.d[0], sizeof(arp_req));
    if (csrResult != CSR_RESULT_SUCCESS)
    {
@@ -2410,8 +2408,6 @@ void uf_send_disconnected_ind_wq(struct work_struct *work)
    struct list_head send_cfm_list;
    u8 j;
-    func_enter();
    if(!staInfo) {
        return;
    }

--- a/drivers/staging/csr/sme_wext.c
+++ b/drivers/staging/csr/sme_wext.c
@@ -800,7 +800,6 @@ iwprivsconfwapi(struct net_device *dev, struct iw_request_info *info,
    u8 enable;
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
-    func_enter();
    unifi_trace(priv, UDBG1, "iwprivsconfwapi\n" );
@@ -837,7 +836,6 @@ iwprivswpikey(struct net_device *dev, struct iw_request_info *info,
    unifiio_wapi_key_t inKey;
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
-    func_enter();
    unifi_trace(priv, UDBG1, "iwprivswpikey\n" );
@@ -914,7 +912,6 @@ unifi_siwfreq(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    struct iw_freq *freq = (struct iw_freq *)wrqu;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwfreq\n");
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -950,7 +947,6 @@ unifi_giwfreq(struct net_device *dev, struct iw_request_info *info,
    int err = 0;
    CsrWifiSmeConnectionInfo connectionInfo;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_giwfreq\n");
    CHECK_INITED(priv);
@@ -982,7 +978,6 @@ unifi_siwmode(struct net_device *dev, struct iw_request_info *info,
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwmode\n");
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -1026,7 +1021,6 @@ unifi_giwmode(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    CsrWifiSmeConnectionConfig connectionConfig;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_giwmode\n");
    CHECK_INITED(priv);
@@ -1192,8 +1186,6 @@ unifi_siwap(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    int err = 0;
-    func_enter();
    CHECK_INITED(priv);
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -1255,8 +1247,6 @@ unifi_giwap(struct net_device *dev, struct iw_request_info *info,
    int r = 0;
    u8 *bssid;
-    func_enter();
    CHECK_INITED(priv);
    unifi_trace(priv, UDBG2, "unifi_giwap\n");
@@ -1302,8 +1292,6 @@ unifi_siwscan(struct net_device *dev, struct iw_request_info *info,
    struct iw_scan_req *req = (struct iw_scan_req *) extra;
 #endif
-    func_enter();
    CHECK_INITED(priv);
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -1707,7 +1695,6 @@ unifi_siwessid(struct net_device *dev, struct iw_request_info *info,
    int len;
    int err = 0;
-    func_enter();
    CHECK_INITED(priv);
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -1779,7 +1766,6 @@ unifi_giwessid(struct net_device *dev, struct iw_request_info *info,
    CsrWifiSmeConnectionInfo connectionInfo;
    int r = 0;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_giwessid\n");
    CHECK_INITED(priv);
@@ -1821,8 +1807,6 @@ unifi_siwrate(struct net_device *dev, struct iw_request_info *info,
    CsrWifiSmeMibConfig mibConfig;
    int r;
-    func_enter();
    CHECK_INITED(priv);
    unifi_trace(priv, UDBG2, "unifi_siwrate\n");
@@ -1882,7 +1866,6 @@ unifi_giwrate(struct net_device *dev, struct iw_request_info *info,
    CsrWifiSmeMibConfig mibConfig;
    CsrWifiSmeConnectionStats connectionStats;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_giwrate\n");
    CHECK_INITED(priv);
@@ -2081,7 +2064,6 @@ unifi_siwencode(struct net_device *dev, struct iw_request_info *info,
    int privacy = -1;
    CsrWifiSmeKey sme_key;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwencode\n");
    CHECK_INITED(priv);
@@ -2467,7 +2449,6 @@ unifi_siwmlme(struct net_device *dev, struct iw_request_info *info,
    netInterface_priv_t *interfacePriv = (netInterface_priv_t *)netdev_priv(dev);
    unifi_priv_t *priv = interfacePriv->privPtr;
    struct iw_mlme *mlme = (struct iw_mlme *)extra;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwmlme\n");
    CHECK_INITED(priv);
@@ -2529,7 +2510,6 @@ unifi_siwgenie(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    int len;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwgenie\n");
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -2574,7 +2554,6 @@ unifi_giwgenie(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    int len;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_giwgenie\n");
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -2627,7 +2606,6 @@ _unifi_siwauth(struct net_device *dev, struct iw_request_info *info,
    unifi_priv_t *priv = interfacePriv->privPtr;
    CsrWifiSmeAuthModeMask new_auth;
-    func_enter();
    unifi_trace(priv, UDBG2, "unifi_siwauth\n");
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||
@@ -2911,8 +2889,6 @@ _unifi_siwencodeext(struct net_device *dev, struct iw_request_info *info,
    CsrWifiSmeKey sme_key;
    CsrWifiSmeKeyType key_type;
-    func_enter();
    CHECK_INITED(priv);
    if(interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP ||

--- a/drivers/staging/csr/unifi_event.c
+++ b/drivers/staging/csr/unifi_event.c
@@ -376,8 +376,6 @@ unifi_process_receive_event(void *ospriv,
    s16 signal_id;
    u8 pktIndToSme = FALSE, freeBulkData = FALSE;
-    func_enter();
    unifi_trace(priv, UDBG5, "unifi_process_receive_event: "
                "%04x %04x %04x %04x %04x %04x %04x %04x (%d)\n",
                CSR_GET_UINT16_FROM_LITTLE_ENDIAN((sigdata) + sizeof(s16)*0) & 0xFFFF,
@@ -587,7 +585,6 @@ void unifi_rx_queue_flush(void *ospriv)
 {
    unifi_priv_t *priv = (unifi_priv_t*)ospriv;
-    func_enter();
    unifi_trace(priv, UDBG4, "rx_wq_handler: RdPtr = %d WritePtr =  %d\n",
                priv->rxSignalBuffer.readPointer,priv->rxSignalBuffer.writePointer);
    if(priv != NULL) {
@@ -655,7 +652,6 @@ unifi_receive_event(void *ospriv,
    u8 writePointer;
    int i;
    rx_buff_struct_t * rx_buff;
-    func_enter();
    unifi_trace(priv, UDBG5, "unifi_receive_event: "
            "%04x %04x %04x %04x %04x %04x %04x %04x (%d)\n",

--- a/drivers/staging/csr/unifi_os.h
+++ b/drivers/staging/csr/unifi_os.h
@@ -61,12 +61,6 @@ extern int unifi_debug;
 * etc.
 */
-#define func_enter()                                    \
-    do {                                                \
-        if (unifi_debug >= 5) {                         \
-            printk("unifi: => %s\n", __FUNCTION__);     \
-        }                                               \
-    } while (0)
 #define func_exit()                                     \
    do {                                                \
        if (unifi_debug >= 5) {                         \
@@ -107,7 +101,6 @@ void unifi_trace(void* ospriv, int level, const char *fmt, ...);
 #else
 /* Stubs */
-#define func_enter()
 #define func_exit()
 #define func_exit_r(_rc)

--- a/drivers/staging/csr/unifi_pdu_processing.c
+++ b/drivers/staging/csr/unifi_pdu_processing.c
@@ -2023,7 +2023,6 @@ u8 send_multicast_frames(unifi_priv_t *priv, u16 interfaceTag)
    netInterface_priv_t *interfacePriv = priv->interfacePriv[interfaceTag];
    u32 hostTag = 0xffffffff;
-    func_enter();
    if(!isRouterBufferEnabled(priv,UNIFI_TRAFFIC_Q_VO)) {
        while((interfacePriv->dtimActive)&& (buffered_pkt=dequeue_tx_data_pdu(priv,&interfacePriv->genericMulticastOrBroadCastMgtFrames))) {
            buffered_pkt->transmissionControl |= (TRANSMISSION_CONTROL_TRIGGER_MASK);
@@ -2123,7 +2122,6 @@ void uf_process_ma_vif_availibility_ind(unifi_priv_t *priv,u8 *sigdata,
    CSR_RESULT_CODE resultCode = CSR_RC_SUCCESS;
    netInterface_priv_t *interfacePriv;
-    func_enter();
    unifi_trace(priv, UDBG3,
            "uf_process_ma_vif_availibility_ind: Process signal 0x%.4X\n",
            *((u16*)sigdata));
@@ -2368,8 +2366,6 @@ void uf_send_buffered_data_from_ac(unifi_priv_t *priv,
    u8 moreData = FALSE;
    s8 r =0;
-    func_enter();
    unifi_trace(priv,UDBG2,"uf_send_buffered_data_from_ac :\n");
    while(!isRouterBufferEnabled(priv,queue) &&
@@ -2415,7 +2411,6 @@ void uf_send_buffered_frames(unifi_priv_t *priv,unifi_TrafficQueue q)
    if(!((interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_AP) ||
        (interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_P2PGO)))
        return;
-    func_enter();
    queue = (q<=3)?q:0;
@@ -2769,7 +2764,6 @@ void uf_send_qos_null(unifi_priv_t * priv,u16 interfaceTag, const u8 *da,CSR_PRI
    CSR_RATE transmitRate = 0;
-    func_enter();
    /* Send a Null Frame to Peer,
     * 32= size of mac header  */
    csrResult = unifi_net_data_malloc(priv, &bulkdata.d[0], MAC_HEADER_SIZE + QOS_CONTROL_HEADER_SIZE);
@@ -2841,7 +2835,6 @@ void uf_send_nulldata(unifi_priv_t * priv,u16 interfaceTag, const u8 *da,CSR_PRI
    CSR_MA_PACKET_REQUEST *req = &signal.u.MaPacketRequest;
    unsigned long lock_flags;
-    func_enter();
    /* Send a Null Frame to Peer, size = 24 for MAC header */
    csrResult = unifi_net_data_malloc(priv, &bulkdata.d[0], MAC_HEADER_SIZE);
@@ -3326,8 +3319,6 @@ void uf_prepare_send_cfm_list_for_queued_pkts(unifi_priv_t * priv,
    struct list_head *placeHolder;
    unsigned long lock_flags;
-    func_enter();
    spin_lock_irqsave(&priv->tx_q_lock,lock_flags);
    /* Search through the list and if confirmation required for any frames,
@@ -3594,7 +3585,6 @@ void resume_unicast_buffered_frames(unifi_priv_t *priv, u16 interfaceTag)
   int r;
   unsigned long lock_flags;
-   func_enter();
   while(!isRouterBufferEnabled(priv,3) &&
                            ((buffered_pkt=dequeue_tx_data_pdu(priv,&interfacePriv->genericMgtFrames))!=NULL)) {
        buffered_pkt->transmissionControl &=
@@ -3682,7 +3672,6 @@ void update_eosp_to_head_of_broadcast_list_head(unifi_priv_t *priv,u16 interface
    struct list_head *placeHolder;
    tx_buffered_packets_t *tx_q_item;
-    func_enter();
    if (interfacePriv->noOfbroadcastPktQueued) {
        /* Update the EOSP to the HEAD of b/c list

--- a/drivers/staging/csr/unifi_sme.c
+++ b/drivers/staging/csr/unifi_sme.c
@@ -78,7 +78,6 @@ sme_log_event(ul_client_t *pcli,
    CsrResult result = CSR_RESULT_SUCCESS;
    int r;
-    func_enter();
    /* Just a sanity check */
    if ((signal == NULL) || (signal_len <= 0)) {
        func_exit();
@@ -1158,8 +1157,6 @@ uf_send_m4_ready_wq(struct work_struct *work)
    CsrWifiMacAddress peer;
    unsigned long flags;
-    func_enter();
    /* The peer address was stored in the signal */
    spin_lock_irqsave(&priv->m4_lock, flags);
    memcpy(peer.a, req->Ra.x, sizeof(peer.a));
@@ -1204,8 +1201,6 @@ void uf_send_pkt_to_encrypt(struct work_struct *work)
    if (interfacePriv->interfaceMode == CSR_WIFI_ROUTER_CTRL_MODE_STA) {
-        func_enter();
        pktBulkDataLength = interfacePriv->wapi_unicast_bulk_data.data_length;
        if (pktBulkDataLength > 0) {