Commit 43dc2ad5 authored by Jimmy Kizito's avatar Jimmy Kizito Committed by Alex Deucher

drm/amd/display: Fix MST link encoder availability check.

[Why]
MST streams share the same link and should share the same encoder.
The current availability check may erroneously determine that an
encoder is unavailable for MST streams.

[How]
When checking for link encoder availability, check if an encoder
in use shares a link with the stream for which the availability
check is being conducted. If the link is shared, then the link
encoder should be shared too and will be deemed available.
Reviewed-by: default avatarJun Lei <Jun.Lei@amd.com>
Acked-by: default avatarAnson Jacob <Anson.Jacob@amd.com>
Signed-off-by: default avatarJimmy Kizito <Jimmy.Kizito@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e3ab29aa
/* /* Copyright 2021 Advanced Micro Devices, Inc. All rights reserved.
* Copyright 2021 Advanced Micro Devices, Inc.
* *
* Permission is hereby granted, free of charge, to any person obtaining a * Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"), * copy of this software and associated documentation files (the "Software"),
...@@ -177,13 +176,27 @@ static enum engine_id find_first_avail_link_enc( ...@@ -177,13 +176,27 @@ static enum engine_id find_first_avail_link_enc(
return eng_id; return eng_id;
} }
static bool is_avail_link_enc(struct dc_state *state, enum engine_id eng_id) /* Check for availability of link encoder eng_id. */
static bool is_avail_link_enc(struct dc_state *state, enum engine_id eng_id, struct dc_stream_state *stream)
{ {
bool is_avail = false; bool is_avail = false;
int eng_idx = eng_id - ENGINE_ID_DIGA; int eng_idx = eng_id - ENGINE_ID_DIGA;
if (eng_id != ENGINE_ID_UNKNOWN && state->res_ctx.link_enc_cfg_ctx.link_enc_avail[eng_idx] != ENGINE_ID_UNKNOWN) /* An encoder is available if it is still in the availability pool. */
if (eng_id != ENGINE_ID_UNKNOWN && state->res_ctx.link_enc_cfg_ctx.link_enc_avail[eng_idx] != ENGINE_ID_UNKNOWN) {
is_avail = true; is_avail = true;
} else {
struct dc_stream_state *stream_assigned = NULL;
/* MST streams share the same link and should share the same encoder.
* If a stream that has already been assigned a link encoder uses as the
* same link as the stream checking for availability, it is an MST stream
* and should use the same link encoder.
*/
stream_assigned = get_stream_using_link_enc(state, eng_id);
if (stream_assigned && stream != stream_assigned && stream->link == stream_assigned->link)
is_avail = true;
}
return is_avail; return is_avail;
} }
...@@ -296,7 +309,7 @@ void link_enc_cfg_link_encs_assign( ...@@ -296,7 +309,7 @@ void link_enc_cfg_link_encs_assign(
if (stream == prev_stream && stream->link == prev_stream->link && if (stream == prev_stream && stream->link == prev_stream->link &&
prev_state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[j].valid) { prev_state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[j].valid) {
eng_id = prev_state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[j].eng_id; eng_id = prev_state->res_ctx.link_enc_cfg_ctx.link_enc_assignments[j].eng_id;
if (is_avail_link_enc(state, eng_id)) if (is_avail_link_enc(state, eng_id, stream))
add_link_enc_assignment(state, stream, eng_id); add_link_enc_assignment(state, stream, eng_id);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment