Commit 4436156b authored by Xin Long's avatar Xin Long Committed by David S. Miller

bridge: simplify the stp_state_store by calling store_bridge_parm

There are some repetitive codes in stp_state_store, we can remove
them by calling store_bridge_parm.
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Reviewed-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 347db6b4
...@@ -128,27 +128,21 @@ static ssize_t stp_state_show(struct device *d, ...@@ -128,27 +128,21 @@ static ssize_t stp_state_show(struct device *d,
} }
static ssize_t stp_state_store(struct device *d, static int set_stp_state(struct net_bridge *br, unsigned long val)
struct device_attribute *attr, const char *buf,
size_t len)
{ {
struct net_bridge *br = to_bridge(d);
char *endp;
unsigned long val;
if (!ns_capable(dev_net(br->dev)->user_ns, CAP_NET_ADMIN))
return -EPERM;
val = simple_strtoul(buf, &endp, 0);
if (endp == buf)
return -EINVAL;
if (!rtnl_trylock()) if (!rtnl_trylock())
return restart_syscall(); return restart_syscall();
br_stp_set_enabled(br, val); br_stp_set_enabled(br, val);
rtnl_unlock(); rtnl_unlock();
return len; return 0;
}
static ssize_t stp_state_store(struct device *d,
struct device_attribute *attr, const char *buf,
size_t len)
{
return store_bridge_parm(d, buf, len, set_stp_state);
} }
static DEVICE_ATTR_RW(stp_state); static DEVICE_ATTR_RW(stp_state);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment