Commit 445783d0 authored by David Howells's avatar David Howells

afs: Fix an off-by-one error in afs_send_pages()

afs_send_pages() should only put the call into the AFS_CALL_AWAIT_REPLY
state if it has sent all the pages - but the check it makes is incorrect
and sometimes it will finish the loop early.
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 7286a35e
...@@ -315,7 +315,7 @@ static int afs_send_pages(struct afs_call *call, struct msghdr *msg) ...@@ -315,7 +315,7 @@ static int afs_send_pages(struct afs_call *call, struct msghdr *msg)
* packet as RxRPC might give us the reply before it * packet as RxRPC might give us the reply before it
* returns from sending the request. * returns from sending the request.
*/ */
if (first + nr >= last) if (first + nr - 1 >= last)
call->state = AFS_CALL_AWAIT_REPLY; call->state = AFS_CALL_AWAIT_REPLY;
ret = rxrpc_kernel_send_data(afs_socket, call->rxcall, ret = rxrpc_kernel_send_data(afs_socket, call->rxcall,
msg, bytes); msg, bytes);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment