Commit 4479730e authored by Thomas Gleixner's avatar Thomas Gleixner

Revert "clocksource/drivers/timer-probe: Avoid creating dead devices"

This reverts commit 4f41fe38.

The change breaks systems on which the DT node of a device is used by
multiple drivers. The proposed workaround to clear OF_POPULATED is just a
band aid and this needs to be cleaned up at the root of the problem.

Revert this for now.
Reported-by: default avatarIonela Voinescu <ionela.voinescu@arm.com>
Reported-by: default avatarJon Hunter <jonathanh@nvidia.com>
Requested-by: default avatarRob Herring <robh+dt@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Saravana Kannan <saravanak@google.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200324175955.GA16972@arm.com
parent ca214e2c
...@@ -27,10 +27,8 @@ void __init timer_probe(void) ...@@ -27,10 +27,8 @@ void __init timer_probe(void)
init_func_ret = match->data; init_func_ret = match->data;
of_node_set_flag(np, OF_POPULATED);
ret = init_func_ret(np); ret = init_func_ret(np);
if (ret) { if (ret) {
of_node_clear_flag(np, OF_POPULATED);
if (ret != -EPROBE_DEFER) if (ret != -EPROBE_DEFER)
pr_err("Failed to initialize '%pOF': %d\n", np, pr_err("Failed to initialize '%pOF': %d\n", np,
ret); ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment