Commit 451f0b6f authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe

block: default BLOCK_LEGACY_AUTOLOAD to y

As Luis reported, losetup currently doesn't properly create the loop
device without this if the device node already exists because old
scripts created it manually.  So default to y for now and remove the
aggressive removal schedule.
Reported-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220225181440.1351591-1-hch@lst.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 86d73312
...@@ -28,15 +28,13 @@ if BLOCK ...@@ -28,15 +28,13 @@ if BLOCK
config BLOCK_LEGACY_AUTOLOAD config BLOCK_LEGACY_AUTOLOAD
bool "Legacy autoloading support" bool "Legacy autoloading support"
default y
help help
Enable loading modules and creating block device instances based on Enable loading modules and creating block device instances based on
accesses through their device special file. This is a historic Linux accesses through their device special file. This is a historic Linux
feature and makes no sense in a udev world where device files are feature and makes no sense in a udev world where device files are
created on demand. created on demand, but scripts that manually create device nodes and
then call losetup might rely on this behavior.
Say N here unless booting or other functionality broke without it, in
which case you should also send a report to your distribution and
linux-block@vger.kernel.org.
config BLK_RQ_ALLOC_TIME config BLK_RQ_ALLOC_TIME
bool bool
......
...@@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev) ...@@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
inode = ilookup(blockdev_superblock, dev); inode = ilookup(blockdev_superblock, dev);
if (inode) if (inode)
pr_warn_ratelimited( pr_warn_ratelimited(
"block device autoloading is deprecated. It will be removed in Linux 5.19\n"); "block device autoloading is deprecated and will be removed.\n");
} }
if (!inode) if (!inode)
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment