Commit 4538d0ca authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Benjamin Herrenschmidt

powerpc: Fix no interrupt handling in pata_of_platform

When no interrupt is specified the pata_of_platform fills the irq_res
resource with -1, which is wrong to do for two reasons:

1. By definition, 'no irq' should be IRQ 0, not some negative integer;
2. pata_platform checks for irq_res.start > 0, but since irq_res.start
   is unsigned type, the check will be true for `-1'.
Reported-by: default avatarSteven A. Falco <sfalco@harris.com>
Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 9fd3f88c
...@@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct of_device *ofdev, ...@@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct of_device *ofdev,
ret = of_irq_to_resource(dn, 0, &irq_res); ret = of_irq_to_resource(dn, 0, &irq_res);
if (ret == NO_IRQ) if (ret == NO_IRQ)
irq_res.start = irq_res.end = -1; irq_res.start = irq_res.end = 0;
else else
irq_res.flags = 0; irq_res.flags = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment