Commit 45c30d80 authored by Rodrigo Vivi's avatar Rodrigo Vivi

drm/xe/uapi: Rename *_mem_regions masks

- 'native' doesn't make much sense on integrated devices.
- 'slow' is not necessarily true and doesn't go well with opposition
  to 'native'.

Instead, let's use 'near' vs 'far'. It makes sense with all the current
Intel GPUs and it is future proof. Right now, there's absolutely no need
to define among the 'far' memory, which ones are slower, either in terms
of latency, nunmber of hops or bandwidth.

In case of this might become a requirement in the future, a new query
could be added to indicate the certain 'distance' between a given engine
and a memory_region. But for now, this fulfill all of the current
requirements in the most straightforward way for the userspace drivers.
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarFrancois Dugast <francois.dugast@intel.com>
Reviewed-by: default avatarMatt Roper <matthew.d.roper@intel.com>
Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
parent 5ca2c4b8
......@@ -377,12 +377,12 @@ static int query_gt_list(struct xe_device *xe, struct drm_xe_device_query *query
gt_list->gt_list[id].gt_id = gt->info.id;
gt_list->gt_list[id].clock_freq = gt->info.clock_freq;
if (!IS_DGFX(xe))
gt_list->gt_list[id].native_mem_regions = 0x1;
gt_list->gt_list[id].near_mem_regions = 0x1;
else
gt_list->gt_list[id].native_mem_regions =
gt_list->gt_list[id].near_mem_regions =
BIT(gt_to_tile(gt)->id) << 1;
gt_list->gt_list[id].slow_mem_regions = xe->info.mem_region_mask ^
gt_list->gt_list[id].native_mem_regions;
gt_list->gt_list[id].far_mem_regions = xe->info.mem_region_mask ^
gt_list->gt_list[id].near_mem_regions;
}
if (copy_to_user(query_ptr, gt_list, size)) {
......
......@@ -349,17 +349,19 @@ struct drm_xe_query_gt {
/** @clock_freq: A clock frequency for timestamp */
__u32 clock_freq;
/**
* @native_mem_regions: Bit mask of instances from
* drm_xe_query_mem_usage that lives on the same GPU/Tile and have
* direct access.
* @near_mem_regions: Bit mask of instances from
* drm_xe_query_mem_usage that are nearest to the current engines
* of this GT.
*/
__u64 native_mem_regions;
__u64 near_mem_regions;
/**
* @slow_mem_regions: Bit mask of instances from
* drm_xe_query_mem_usage that this GT can indirectly access, although
* they live on a different GPU/Tile.
* @far_mem_regions: Bit mask of instances from
* drm_xe_query_mem_usage that are far from the engines of this GT.
* In general, they have extra indirections when compared to the
* @near_mem_regions. For a discrete device this could mean system
* memory and memory living in a different tile.
*/
__u64 slow_mem_regions;
__u64 far_mem_regions;
/** @reserved: Reserved */
__u64 reserved[8];
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment