Commit 46ceff78 authored by Ronnie Sahlberg's avatar Ronnie Sahlberg Committed by Thadeu Lima de Souza Cascardo

cifs: check MaxPathNameComponentLength != 0 before using it

BugLink: http://bugs.launchpad.net/bugs/1731915

commit f74bc7c6 upstream.

And fix tcon leak in error path.
Signed-off-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
Reviewed-by: default avatarDavid Disseldorp <ddiss@samba.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@canonical.com>
parent ac87198f
...@@ -193,7 +193,8 @@ check_name(struct dentry *direntry, struct cifs_tcon *tcon) ...@@ -193,7 +193,8 @@ check_name(struct dentry *direntry, struct cifs_tcon *tcon)
struct cifs_sb_info *cifs_sb = CIFS_SB(direntry->d_sb); struct cifs_sb_info *cifs_sb = CIFS_SB(direntry->d_sb);
int i; int i;
if (unlikely(direntry->d_name.len > if (unlikely(tcon->fsAttrInfo.MaxPathNameComponentLength &&
direntry->d_name.len >
le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength))) le32_to_cpu(tcon->fsAttrInfo.MaxPathNameComponentLength)))
return -ENAMETOOLONG; return -ENAMETOOLONG;
...@@ -509,7 +510,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, ...@@ -509,7 +510,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry,
rc = check_name(direntry, tcon); rc = check_name(direntry, tcon);
if (rc) if (rc)
goto out_free_xid; goto out;
server = tcon->ses->server; server = tcon->ses->server;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment