Commit 47ce8527 authored by Martin Fäcknitz's avatar Martin Fäcknitz Committed by Thomas Bogendoerfer

MIPS: vdso: Invalid GIC access through VDSO

Accessing raw timers (currently only CLOCK_MONOTONIC_RAW) through VDSO
doesn't return the correct time when using the GIC as clock source.
The address of the GIC mapped page is in this case not calculated
correctly. The GIC mapped page is calculated from the VDSO data by
subtracting PAGE_SIZE:

  void *get_gic(const struct vdso_data *data) {
    return (void __iomem *)data - PAGE_SIZE;
  }

However, the data pointer is not page aligned for raw clock sources.
This is because the VDSO data for raw clock sources (CS_RAW = 1) is
stored after the VDSO data for coarse clock sources (CS_HRES_COARSE = 0).
Therefore, only the VDSO data for CS_HRES_COARSE is page aligned:

  +--------------------+
  |                    |
  | vd[CS_RAW]         | ---+
  | vd[CS_HRES_COARSE] |    |
  +--------------------+    | -PAGE_SIZE
  |                    |    |
  |  GIC mapped page   | <--+
  |                    |
  +--------------------+

When __arch_get_hw_counter() is called with &vd[CS_RAW], get_gic returns
the wrong address (somewhere inside the GIC mapped page). The GIC counter
values are not returned which results in an invalid time.

Fixes: a7f4df4e ("MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()")
Signed-off-by: default avatarMartin Fäcknitz <faecknitz@hotsplots.de>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 97e48807
...@@ -67,7 +67,7 @@ static inline const struct vdso_data *get_vdso_data(void) ...@@ -67,7 +67,7 @@ static inline const struct vdso_data *get_vdso_data(void)
static inline void __iomem *get_gic(const struct vdso_data *data) static inline void __iomem *get_gic(const struct vdso_data *data)
{ {
return (void __iomem *)data - PAGE_SIZE; return (void __iomem *)((unsigned long)data & PAGE_MASK) - PAGE_SIZE;
} }
#endif /* CONFIG_CLKSRC_MIPS_GIC */ #endif /* CONFIG_CLKSRC_MIPS_GIC */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment