Commit 4808d12d authored by Takashi Iwai's avatar Takashi Iwai

ALSA: hda - Fix the detection of "Loopback Mixing" control for VIA codecs

Currently the driver checks only the out_mix_path[] for the primary
output route for judging whether to create the loopback-mixing control
or not.  But, there are cases where aamix-routing is available only on
headphone or speaker paths but not on the primary output path.  So, the
driver ignores such cases inappropriately.

This patch fixes the check of the loopback-mixing control by testing
all mix-routing paths.

Cc: <stable@kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 3a90274d
...@@ -2208,7 +2208,10 @@ static int via_auto_create_loopback_switch(struct hda_codec *codec) ...@@ -2208,7 +2208,10 @@ static int via_auto_create_loopback_switch(struct hda_codec *codec)
{ {
struct via_spec *spec = codec->spec; struct via_spec *spec = codec->spec;
if (!spec->aa_mix_nid || !spec->out_mix_path.depth) if (!spec->aa_mix_nid)
return 0; /* no loopback switching available */
if (!(spec->out_mix_path.depth || spec->hp_mix_path.depth ||
spec->speaker_path.depth))
return 0; /* no loopback switching available */ return 0; /* no loopback switching available */
if (!via_clone_control(spec, &via_aamix_ctl_enum)) if (!via_clone_control(spec, &via_aamix_ctl_enum))
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment