Commit 487ae3b4 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo

perf stat: Don't display zero tool counts

Andi reported (see link below) a regression when printing the
'duration_time' tool event, where it gets printed as "not counted" for
most of the CPUs, fix it by skipping zero counts for tool events.
Reported-by: default avatarAndi Kleen <ak@linux.intel.com>
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Tested-by: default avatarAndi Kleen <ak@linux.intel.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Claire Jensen <cjense@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/all/ZMlrzcVrVi1lTDmn@tassilo/Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 8cdd4aef
...@@ -931,6 +931,11 @@ static bool should_skip_zero_counter(struct perf_stat_config *config, ...@@ -931,6 +931,11 @@ static bool should_skip_zero_counter(struct perf_stat_config *config,
*/ */
if (config->aggr_mode == AGGR_THREAD && config->system_wide) if (config->aggr_mode == AGGR_THREAD && config->system_wide)
return true; return true;
/* Tool events have the software PMU but are only gathered on 1. */
if (evsel__is_tool(counter))
return true;
/* /*
* Skip value 0 when it's an uncore event and the given aggr id * Skip value 0 when it's an uncore event and the given aggr id
* does not belong to the PMU cpumask. * does not belong to the PMU cpumask.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment