Commit 488d9a48 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Kalle Valo

wifi: ath12k: Add missing unwind goto in ath12k_pci_probe()

Smatch Warns:
	drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
	warn: missing unwind goto?

Store the error value in ret and use correct label with a goto.

Only Compile tested, found with Smatch.

Fixes: d8899132 ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/Suggested-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230307104706.240119-1-harshit.m.mogalapalli@oracle.com
parent f9455715
...@@ -1223,7 +1223,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev, ...@@ -1223,7 +1223,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev,
dev_err(&pdev->dev, dev_err(&pdev->dev,
"Unknown hardware version found for QCN9274: 0x%x\n", "Unknown hardware version found for QCN9274: 0x%x\n",
soc_hw_version_major); soc_hw_version_major);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto err_pci_free_region;
} }
break; break;
case WCN7850_DEVICE_ID: case WCN7850_DEVICE_ID:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment