Commit 4923abf9 authored by Linus Torvalds's avatar Linus Torvalds

Don't warn about order-1 allocations with __GFP_NOFAIL

Traditionally, we never failed small orders (even regardless of any
__GFP_NOFAIL flags), and slab will allocate order-1 allocations even for
small allocations that could fit in a single page (in order to avoid
excessive fragmentation).

Maybe we should remove this warning entirely, but before making that
judgement, at least limit it to bigger allocations.
Acked-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c82e6d45
...@@ -1153,10 +1153,10 @@ struct page *buffered_rmqueue(struct zone *preferred_zone, ...@@ -1153,10 +1153,10 @@ struct page *buffered_rmqueue(struct zone *preferred_zone,
* properly detect and handle allocation failures. * properly detect and handle allocation failures.
* *
* We most definitely don't want callers attempting to * We most definitely don't want callers attempting to
* allocate greater than single-page units with * allocate greater than order-1 page units with
* __GFP_NOFAIL. * __GFP_NOFAIL.
*/ */
WARN_ON_ONCE(order > 0); WARN_ON_ONCE(order > 1);
} }
spin_lock_irqsave(&zone->lock, flags); spin_lock_irqsave(&zone->lock, flags);
page = __rmqueue(zone, order, migratetype); page = __rmqueue(zone, order, migratetype);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment