Commit 49446e57 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bjorn Andersson

rpmsg: qcom_glink_rpm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230321154039.355098-3-u.kleine-koenig@pengutronix.de
parent 810c03d9
...@@ -361,7 +361,7 @@ static int glink_rpm_probe(struct platform_device *pdev) ...@@ -361,7 +361,7 @@ static int glink_rpm_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int glink_rpm_remove(struct platform_device *pdev) static void glink_rpm_remove(struct platform_device *pdev)
{ {
struct glink_rpm *rpm = platform_get_drvdata(pdev); struct glink_rpm *rpm = platform_get_drvdata(pdev);
struct qcom_glink *glink = rpm->glink; struct qcom_glink *glink = rpm->glink;
...@@ -371,8 +371,6 @@ static int glink_rpm_remove(struct platform_device *pdev) ...@@ -371,8 +371,6 @@ static int glink_rpm_remove(struct platform_device *pdev)
qcom_glink_native_remove(glink); qcom_glink_native_remove(glink);
mbox_free_channel(rpm->mbox_chan); mbox_free_channel(rpm->mbox_chan);
return 0;
} }
static const struct of_device_id glink_rpm_of_match[] = { static const struct of_device_id glink_rpm_of_match[] = {
...@@ -383,7 +381,7 @@ MODULE_DEVICE_TABLE(of, glink_rpm_of_match); ...@@ -383,7 +381,7 @@ MODULE_DEVICE_TABLE(of, glink_rpm_of_match);
static struct platform_driver glink_rpm_driver = { static struct platform_driver glink_rpm_driver = {
.probe = glink_rpm_probe, .probe = glink_rpm_probe,
.remove = glink_rpm_remove, .remove_new = glink_rpm_remove,
.driver = { .driver = {
.name = "qcom_glink_rpm", .name = "qcom_glink_rpm",
.of_match_table = glink_rpm_of_match, .of_match_table = glink_rpm_of_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment