Commit 49952fa1 authored by Jaegeuk Kim's avatar Jaegeuk Kim

f2fs: reduce redundant spin_lock operations

This patch reduces redundant spin_lock operations in alloc_nid_failed().
The alloc_nid_failed() does not need to delete entry and add one again
by triggering spin_lock and spin_unlock redundantly.
Signed-off-by: default avatarJaegeuk Kim <jaegeuk.kim@samsung.com>
parent 1571f84a
...@@ -1407,10 +1407,8 @@ void alloc_nid_done(struct f2fs_sb_info *sbi, nid_t nid) ...@@ -1407,10 +1407,8 @@ void alloc_nid_done(struct f2fs_sb_info *sbi, nid_t nid)
spin_lock(&nm_i->free_nid_list_lock); spin_lock(&nm_i->free_nid_list_lock);
i = __lookup_free_nid_list(nid, &nm_i->free_nid_list); i = __lookup_free_nid_list(nid, &nm_i->free_nid_list);
if (i) { BUG_ON(!i || i->state != NID_ALLOC);
BUG_ON(i->state != NID_ALLOC); __del_from_free_nid_list(i);
__del_from_free_nid_list(i);
}
spin_unlock(&nm_i->free_nid_list_lock); spin_unlock(&nm_i->free_nid_list_lock);
} }
...@@ -1419,8 +1417,15 @@ void alloc_nid_done(struct f2fs_sb_info *sbi, nid_t nid) ...@@ -1419,8 +1417,15 @@ void alloc_nid_done(struct f2fs_sb_info *sbi, nid_t nid)
*/ */
void alloc_nid_failed(struct f2fs_sb_info *sbi, nid_t nid) void alloc_nid_failed(struct f2fs_sb_info *sbi, nid_t nid)
{ {
alloc_nid_done(sbi, nid); struct f2fs_nm_info *nm_i = NM_I(sbi);
add_free_nid(NM_I(sbi), nid); struct free_nid *i;
spin_lock(&nm_i->free_nid_list_lock);
i = __lookup_free_nid_list(nid, &nm_i->free_nid_list);
BUG_ON(!i || i->state != NID_ALLOC);
i->state = NID_NEW;
nm_i->fcnt++;
spin_unlock(&nm_i->free_nid_list_lock);
} }
void recover_node_page(struct f2fs_sb_info *sbi, struct page *page, void recover_node_page(struct f2fs_sb_info *sbi, struct page *page,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment