Commit 4a0467ed authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Dmitry Torokhov

Input: zforce_ts - use devm_add_action_or_reset()

If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated. Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup
function has been already called by the helper if there was any error.
Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Reviewed-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: Andreas Kemnade <andreas@kemnade.info> # Tolino Shine2HD
Link: https://lore.kernel.org/r/20240824055047.1706392-2-dmitry.torokhov@gmail.comSigned-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 78af00d8
...@@ -803,15 +803,12 @@ static int zforce_probe(struct i2c_client *client) ...@@ -803,15 +803,12 @@ static int zforce_probe(struct i2c_client *client)
udelay(100); udelay(100);
} }
ret = devm_add_action(&client->dev, zforce_reset, ts); ret = devm_add_action_or_reset(&client->dev, zforce_reset, ts);
if (ret) { if (ret) {
dev_err(&client->dev, "failed to register reset action, %d\n", dev_err(&client->dev, "failed to register reset action, %d\n",
ret); ret);
/* hereafter the regulator will be disabled by the action */ /* hereafter the regulator will be disabled by the action */
if (!IS_ERR(ts->reg_vdd))
regulator_disable(ts->reg_vdd);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment