Commit 4bcf349a authored by Paul Mackerras's avatar Paul Mackerras Committed by Ingo Molnar

perfcounters: fix refcounting bug, take 2

Only free child_counter if it has a parent; if it doesn't, then it
has a file pointing to it and we'll free it in perf_release.
Signed-off-by: default avatarMike Galbraith <efault@gmx.de>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 5af75917
...@@ -1958,14 +1958,13 @@ __perf_counter_exit_task(struct task_struct *child, ...@@ -1958,14 +1958,13 @@ __perf_counter_exit_task(struct task_struct *child,
sync_child_counter(child_counter, parent_counter); sync_child_counter(child_counter, parent_counter);
list_for_each_entry_safe(sub, tmp, &child_counter->sibling_list, list_for_each_entry_safe(sub, tmp, &child_counter->sibling_list,
list_entry) { list_entry) {
if (sub->parent) if (sub->parent) {
sync_child_counter(sub, sub->parent); sync_child_counter(sub, sub->parent);
kfree(sub); kfree(sub);
}
} }
}
if (!child_counter->filp || !atomic_long_read(&child_counter->filp->f_count))
kfree(child_counter); kfree(child_counter);
}
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment