Commit 4cdbf7c3 authored by Grygorii Strashko's avatar Grygorii Strashko Committed by Seth Forshee

drivers: net: cpsw: remove pm runtime calls from suspend callbacks

BugLink: http://bugs.launchpad.net/bugs/1625177

PM runtime is properly handled in cpsw_ndo_open/stop(), as result it
isn't required to duplicate these calls in .suspend()/.resume()
callbacks. Moreover, it might cause unnecessary RPM resume of CPSW
during System suspend in the case it's already suspended because
all ethX interfaces are down already, before System suspend started.
Signed-off-by: default avatarGrygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
(cherry picked from commit 74556f51)
Signed-off-by: default avatarPaolo Pisati <paolo.pisati@canonical.com>
Acked-by: default avatarTim Gardner <tim.gardner@canonical.com>
Signed-off-by: default avatarKamal Mostafa <kamal@canonical.com>
parent efdd9a5e
...@@ -2576,8 +2576,6 @@ static int cpsw_suspend(struct device *dev) ...@@ -2576,8 +2576,6 @@ static int cpsw_suspend(struct device *dev)
cpsw_ndo_stop(ndev); cpsw_ndo_stop(ndev);
} }
pm_runtime_put_sync(&pdev->dev);
/* Select sleep pin state */ /* Select sleep pin state */
pinctrl_pm_select_sleep_state(&pdev->dev); pinctrl_pm_select_sleep_state(&pdev->dev);
...@@ -2590,8 +2588,6 @@ static int cpsw_resume(struct device *dev) ...@@ -2590,8 +2588,6 @@ static int cpsw_resume(struct device *dev)
struct net_device *ndev = platform_get_drvdata(pdev); struct net_device *ndev = platform_get_drvdata(pdev);
struct cpsw_priv *priv = netdev_priv(ndev); struct cpsw_priv *priv = netdev_priv(ndev);
pm_runtime_get_sync(&pdev->dev);
/* Select default pin state */ /* Select default pin state */
pinctrl_pm_select_default_state(&pdev->dev); pinctrl_pm_select_default_state(&pdev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment