Commit 4d51419d authored by Ilya Maximets's avatar Ilya Maximets Committed by David S. Miller

openvswitch: fix send of uninitialized stack memory in ct limit reply

'struct ovs_zone_limit' has more members than initialized in
ovs_ct_limit_get_default_limit().  The rest of the memory is a random
kernel stack content that ends up being sent to userspace.

Fix that by using designated initializer that will clear all
non-specified fields.

Fixes: 11efd5cb ("openvswitch: Support conntrack zone limit")
Signed-off-by: default avatarIlya Maximets <i.maximets@ovn.org>
Acked-by: default avatarTonghao Zhang <xiangxia.m.yue@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a14d273b
...@@ -2034,10 +2034,10 @@ static int ovs_ct_limit_del_zone_limit(struct nlattr *nla_zone_limit, ...@@ -2034,10 +2034,10 @@ static int ovs_ct_limit_del_zone_limit(struct nlattr *nla_zone_limit,
static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info, static int ovs_ct_limit_get_default_limit(struct ovs_ct_limit_info *info,
struct sk_buff *reply) struct sk_buff *reply)
{ {
struct ovs_zone_limit zone_limit; struct ovs_zone_limit zone_limit = {
.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE,
zone_limit.zone_id = OVS_ZONE_LIMIT_DEFAULT_ZONE; .limit = info->default_limit,
zone_limit.limit = info->default_limit; };
return nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit); return nla_put_nohdr(reply, sizeof(zone_limit), &zone_limit);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment