Commit 4eb32b48 authored by Jes Sorensen's avatar Jes Sorensen Committed by Greg Kroah-Hartman

staging: unisys: Avoid some == 0 checks

Signed-off-by: default avatarJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: default avatarBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 28723521
...@@ -36,7 +36,7 @@ static struct visorchannel **file_controlvm_channel; ...@@ -36,7 +36,7 @@ static struct visorchannel **file_controlvm_channel;
void void
visorchipset_file_cleanup(dev_t major_dev) visorchipset_file_cleanup(dev_t major_dev)
{ {
if (file_cdev.ops != NULL) if (file_cdev.ops)
cdev_del(&file_cdev); cdev_del(&file_cdev);
file_cdev.ops = NULL; file_cdev.ops = NULL;
unregister_chrdev_region(major_dev, 1); unregister_chrdev_region(major_dev, 1);
...@@ -47,7 +47,7 @@ visorchipset_open(struct inode *inode, struct file *file) ...@@ -47,7 +47,7 @@ visorchipset_open(struct inode *inode, struct file *file)
{ {
unsigned minor_number = iminor(inode); unsigned minor_number = iminor(inode);
if (minor_number != 0) if (minor_number)
return -ENODEV; return -ENODEV;
file->private_data = NULL; file->private_data = NULL;
return 0; return 0;
...@@ -73,16 +73,16 @@ visorchipset_mmap(struct file *file, struct vm_area_struct *vma) ...@@ -73,16 +73,16 @@ visorchipset_mmap(struct file *file, struct vm_area_struct *vma)
switch (offset) { switch (offset) {
case VISORCHIPSET_MMAP_CONTROLCHANOFFSET: case VISORCHIPSET_MMAP_CONTROLCHANOFFSET:
vma->vm_flags |= VM_IO; vma->vm_flags |= VM_IO;
if (*file_controlvm_channel == NULL) { if (!*file_controlvm_channel)
return -ENXIO; return -ENXIO;
}
visorchannel_read(*file_controlvm_channel, visorchannel_read(*file_controlvm_channel,
offsetof(struct spar_controlvm_channel_protocol, offsetof(struct spar_controlvm_channel_protocol,
gp_control_channel), gp_control_channel),
&addr, sizeof(addr)); &addr, sizeof(addr));
if (addr == 0) { if (!addr)
return -ENXIO; return -ENXIO;
}
physaddr = (unsigned long)addr; physaddr = (unsigned long)addr;
if (remap_pfn_range(vma, vma->vm_start, if (remap_pfn_range(vma, vma->vm_start,
physaddr >> PAGE_SHIFT, physaddr >> PAGE_SHIFT,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment