Commit 4ecc933b authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Rafael J. Wysocki

x86: intel_epb: Allow model specific normal EPB value

The current EPB "normal" is defined as 6 and set whenever power-up EPB
value is 0. This setting resulted in the desired out of box power and
performance for several CPU generations. But this value is not suitable
for AlderLake mobile CPUs, as this resulted in higher uncore power.
Since EPB is model specific, this is not unreasonable to have different
behavior.

Allow a capability where "normal" EPB can be redefined. For AlderLake
mobile CPUs this desired normal value is 7.
Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent c9e6606c
...@@ -16,6 +16,7 @@ ...@@ -16,6 +16,7 @@
#include <linux/syscore_ops.h> #include <linux/syscore_ops.h>
#include <linux/pm.h> #include <linux/pm.h>
#include <asm/cpu_device_id.h>
#include <asm/cpufeature.h> #include <asm/cpufeature.h>
#include <asm/msr.h> #include <asm/msr.h>
...@@ -58,6 +59,22 @@ static DEFINE_PER_CPU(u8, saved_epb); ...@@ -58,6 +59,22 @@ static DEFINE_PER_CPU(u8, saved_epb);
#define EPB_SAVED 0x10ULL #define EPB_SAVED 0x10ULL
#define MAX_EPB EPB_MASK #define MAX_EPB EPB_MASK
enum energy_perf_value_index {
EPB_INDEX_PERFORMANCE,
EPB_INDEX_BALANCE_PERFORMANCE,
EPB_INDEX_NORMAL,
EPB_INDEX_BALANCE_POWERSAVE,
EPB_INDEX_POWERSAVE,
};
static u8 energ_perf_values[] = {
[EPB_INDEX_PERFORMANCE] = ENERGY_PERF_BIAS_PERFORMANCE,
[EPB_INDEX_BALANCE_PERFORMANCE] = ENERGY_PERF_BIAS_BALANCE_PERFORMANCE,
[EPB_INDEX_NORMAL] = ENERGY_PERF_BIAS_NORMAL,
[EPB_INDEX_BALANCE_POWERSAVE] = ENERGY_PERF_BIAS_BALANCE_POWERSAVE,
[EPB_INDEX_POWERSAVE] = ENERGY_PERF_BIAS_POWERSAVE,
};
static int intel_epb_save(void) static int intel_epb_save(void)
{ {
u64 epb; u64 epb;
...@@ -90,7 +107,7 @@ static void intel_epb_restore(void) ...@@ -90,7 +107,7 @@ static void intel_epb_restore(void)
*/ */
val = epb & EPB_MASK; val = epb & EPB_MASK;
if (val == ENERGY_PERF_BIAS_PERFORMANCE) { if (val == ENERGY_PERF_BIAS_PERFORMANCE) {
val = ENERGY_PERF_BIAS_NORMAL; val = energ_perf_values[EPB_INDEX_NORMAL];
pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n"); pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
} }
} }
...@@ -103,18 +120,11 @@ static struct syscore_ops intel_epb_syscore_ops = { ...@@ -103,18 +120,11 @@ static struct syscore_ops intel_epb_syscore_ops = {
}; };
static const char * const energy_perf_strings[] = { static const char * const energy_perf_strings[] = {
"performance", [EPB_INDEX_PERFORMANCE] = "performance",
"balance-performance", [EPB_INDEX_BALANCE_PERFORMANCE] = "balance-performance",
"normal", [EPB_INDEX_NORMAL] = "normal",
"balance-power", [EPB_INDEX_BALANCE_POWERSAVE] = "balance-power",
"power" [EPB_INDEX_POWERSAVE] = "power",
};
static const u8 energ_perf_values[] = {
ENERGY_PERF_BIAS_PERFORMANCE,
ENERGY_PERF_BIAS_BALANCE_PERFORMANCE,
ENERGY_PERF_BIAS_NORMAL,
ENERGY_PERF_BIAS_BALANCE_POWERSAVE,
ENERGY_PERF_BIAS_POWERSAVE
}; };
static ssize_t energy_perf_bias_show(struct device *dev, static ssize_t energy_perf_bias_show(struct device *dev,
...@@ -193,13 +203,22 @@ static int intel_epb_offline(unsigned int cpu) ...@@ -193,13 +203,22 @@ static int intel_epb_offline(unsigned int cpu)
return 0; return 0;
} }
static const struct x86_cpu_id intel_epb_normal[] = {
X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, 7),
{}
};
static __init int intel_epb_init(void) static __init int intel_epb_init(void)
{ {
const struct x86_cpu_id *id = x86_match_cpu(intel_epb_normal);
int ret; int ret;
if (!boot_cpu_has(X86_FEATURE_EPB)) if (!boot_cpu_has(X86_FEATURE_EPB))
return -ENODEV; return -ENODEV;
if (id)
energ_perf_values[EPB_INDEX_NORMAL] = id->driver_data;
ret = cpuhp_setup_state(CPUHP_AP_X86_INTEL_EPB_ONLINE, ret = cpuhp_setup_state(CPUHP_AP_X86_INTEL_EPB_ONLINE,
"x86/intel/epb:online", intel_epb_online, "x86/intel/epb:online", intel_epb_online,
intel_epb_offline); intel_epb_offline);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment