Commit 502fac1e authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Mauro Carvalho Chehab

media: bt8xx: Remove unnecessary self-assignment

Clang warns when a variable is assigned to itself.

drivers/media/pci/bt8xx/bttv-driver.c:2043:13: warning: explicitly
assigning value of variable of type '__s32' (aka 'int') to itself
[-Wself-assign]
        min_height = min_height;
        ~~~~~~~~~~ ^ ~~~~~~~~~~
1 warning generated.

There doesn't appear to be any good reason for this and this statement
was added in commit e5bd0260 ("V4L/DVB (5077): Bttv cropping
support") back in 2007. Just remove it.
Reported-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent ae5a8ca8
...@@ -2040,7 +2040,6 @@ limit_scaled_size_lock (struct bttv_fh * fh, ...@@ -2040,7 +2040,6 @@ limit_scaled_size_lock (struct bttv_fh * fh,
max_width = max_width & width_mask; max_width = max_width & width_mask;
/* Max. scale factor is 16:1 for frames, 8:1 for fields. */ /* Max. scale factor is 16:1 for frames, 8:1 for fields. */
min_height = min_height;
/* Min. scale factor is 1:1. */ /* Min. scale factor is 1:1. */
max_height >>= !V4L2_FIELD_HAS_BOTH(field); max_height >>= !V4L2_FIELD_HAS_BOTH(field);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment