Commit 509a02df authored by Wolfram Sang's avatar Wolfram Sang Committed by Anatolij Gustschin

Kind of revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"

This more or less reverts commit 6391f697.
Instead of adding an unneeded 'default', mark the variable to prevent
the false positive 'uninitialized var'. The other change (fixing the
printout) needs revert, too. We want to know WHICH critical irq failed,
not which level it had.
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Anatolij Gustschin <agust@denx.de>
Acked-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarAnatolij Gustschin <agust@denx.de>
parent 45d20e83
......@@ -340,7 +340,7 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
{
int l1irq;
int l2irq;
struct irq_chip *irqchip;
struct irq_chip *uninitialized_var(irqchip);
void *hndlr;
int type;
u32 reg;
......@@ -373,9 +373,8 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break;
case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break;
case MPC52xx_IRQ_L1_CRIT:
default:
pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n",
__func__, l1irq);
__func__, l2irq);
irq_set_chip(virq, &no_irq_chip);
return 0;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment